Bugzilla – Attachment 172279 Details for
Bug 37148
Move the filter bar in the 'holds to pull' report from the bottom to the top of the table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37148: [WIP] use built in table filtering
Bug-37148-WIP-use-built-in-table-filtering.patch (text/plain), 3.26 KB, created by
Nick Clemens (kidclamp)
on 2024-10-01 15:02:55 UTC
(
hide
)
Description:
Bug 37148: [WIP] use built in table filtering
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-10-01 15:02:55 UTC
Size:
3.26 KB
patch
obsolete
>From fcb221c0a2af5a2337330de51475f0f9752370f8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 1 Oct 2024 15:02:37 +0000 >Subject: [PATCH] Bug 37148: [WIP] use built in table filtering > >--- > .../prog/en/modules/circ/pendingreserves.tt | 27 +++++-------------- > 1 file changed, 6 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 701aab6dca5..379c4c178f7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -62,6 +62,8 @@ > <h3>Reported on [% todaysdate | $KohaDates %]</h3> > <p>The following holds have not been filled. Please retrieve them and check them in.</p> > <div id="searchresults"> >+ <div class="holdst_table_controls"> >+ </div> > [% IF holds_info %] > <table id="holdst"> > <thead> >@@ -252,25 +254,6 @@ > [% END %] > </tbody> > <tfoot> >- <tr> >- <td><input type="text" class="filter" data-column_num="0" placeholder="Pull this many items" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="1" placeholder="Items available" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="2" placeholder="Patron holds" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="3" placeholder="Patron name" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="4" placeholder="Title" style="width:95%"/></td> >- <td id="homebranchfilter"></td> >- <td></td> >- <td><input type="text" class="filter" data-column_num="7" placeholder="Call number" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="8" placeholder="Available copy" style="width:95%"/></td> >- <td><input type="text" class="filter" data-column_num="9" placeholder="Available enumeration" style="width:95%"/></td> >- <td id="itemtype-filter"></td> >- <td id="locationfilter"></td> >- <td></td> >- <td></td> >- <td></td> >- <td id="pickup-location"></td> >- <td></td> >- </tr> > </tfoot> > </table> > [% ELSE %] >@@ -279,6 +262,7 @@ > </div> > > >+ > </main> > </div> <!-- /.col-md-10.order-md-2 --> > >@@ -325,13 +309,14 @@ > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'columns_settings.inc' %] >+ [% Asset.js("js/table_filters.js") | $raw %] >+ [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %] > <script> > $(document).ready(function() { > var table_settings = [% TablesSettings.GetTableSettings('circ', 'holds', 'holds-to-pull', 'json') | $raw %]; > var holdst = KohaTable("holdst", { > "pagingType": "full_numbers" >- }, table_settings); >- holdst.fnAddFilters("filter"); >+ }, table_settings, true); > [%# add separateData function to cleanse jQuery select lists by breaking apart strings glued with BR tags and then de-duplicating any repeated library codes %] > function separateData ( ColumnData ){ > var cD = ColumnData; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37148
:
168175
|
170759
|
170955
|
172279
|
172280
|
173272
|
174757