Attachment 172280 Details for Bug 37148 – Bug 37148 - Move hold to pull column filters to top

[patch] Bug 37148 - Move hold to pull column filters to top

Bug-37148---Move-hold-to-pull-column-filters-to-to.patch (text/plain), 6.94 KB, created by Nick Clemens (kidclamp) on 2024-10-01 15:04:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-10-01 15:04:15 UTC

Size: 6.94 KB

patch

obsolete

>From 1af68b170cd107655a61d6d531305cff24be4242 Mon Sep 17 00:00:00 2001
>From: PerplexedTheta <jahdobble@llownd.net>
>Date: Tue, 27 Aug 2024 11:48:34 +0100
>Subject: [PATCH] Bug 37148 - Move hold to pull column filters to top
>
>This bug moves the column filters on the holds to pull page (pendingreserves.pl)
>to the table header, similar to how it is being done on shelves.pl. This
>should make it much clearer to users that filtering is possible, and also
>make the filters float on the page, so they are always visible.
>
>To test:
>a)  apply half a dozen holds, with varying item types, shelving locations,
>    holding branches, titles, and collections
>b)  go to pendingreserves.pl
>c)  notice that the filters are in the table's footer, and that you have
>    to scroll down to see them
>d)  APPLY PATCH
>e)  notice that on pendingreserves.pl, the filters present in tfoot are
>    now in thead
>f)  notice that the filters are unchanged, aside from location on page
>g)  notice that the filters now stick to the top of the page, like the
>    headings did
>h)  notice that the headings still change the sort order when clicked
>i)  notice that the filter inputs all still work as expected
>j)  SIGN OFF! :-)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../prog/en/modules/circ/pendingreserves.tt   | 87 +++++++++++--------
> 1 file changed, 49 insertions(+), 38 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>index 701aab6dca5..ed9dd09c099 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>@@ -66,23 +66,42 @@
>     <table id="holdst">
>     <thead>
>         <tr>
>-        <th>Pull this many items</th>
>-        <th>Items available</th>
>-        <th>Patrons with holds</th>
>-        <th>First patron</th>
>-        <th class="anti-the">Title</th>
>-        <th class="string-sort">Libraries</th>
>-        <th>Available barcodes</th>
>-        <th>Available call numbers</th>
>-        <th>Available copy numbers</th>
>-        <th>Available enumeration</th>
>-        <th class="string-sort">Available item types</th>
>-        <th class="string-sort">Available locations</th>
>-        <th class="string-sort">Available collections</th>
>-        <th>Earliest hold date</th>
>-        <th>Hold notes</th>
>-        <th class="string-sort">Pickup location</th>
>-        <th>Action</th>
>+            <th>Pull this many items</th>
>+            <th>Items available</th>
>+            <th>Patrons with holds</th>
>+            <th>First patron</th>
>+            <th class="anti-the">Title</th>
>+            <th class="string-sort">Libraries</th>
>+            <th>Available barcodes</th>
>+            <th>Available call numbers</th>
>+            <th>Available copy numbers</th>
>+            <th>Available enumeration</th>
>+            <th class="string-sort">Available item types</th>
>+            <th class="string-sort">Available locations</th>
>+            <th class="string-sort">Available collections</th>
>+            <th>Earliest hold date</th>
>+            <th>Hold notes</th>
>+            <th class="string-sort">Pickup location</th>
>+            <th>Action</th>
>+        </tr>
>+        <tr class="filters_row">
>+            <th><input type="text" class="filter" data-column_num="0" placeholder="Pull this many items" style="width:95%"/></th>
>+            <th><input type="text" class="filter" data-column_num="1" placeholder="Items available" style="width:95%"/></th>
>+            <th><input type="text" class="filter" data-column_num="2" placeholder="Patron holds" style="width:95%"/></th>
>+            <th><input type="text" class="filter" data-column_num="3" placeholder="Patron name" style="width:95%"/></th>
>+            <th><input type="text" class="filter" data-column_num="4" placeholder="Title" style="width:95%"/></th>
>+            <th id="homebranchfilter"></th>
>+            <th></th>
>+            <th><input type="text" class="filter" data-column_num="7" placeholder="Call number" style="width:95%"/></th>
>+            <th><input type="text" class="filter" data-column_num="8" placeholder="Available copy" style="width:95%"/></th>
>+            <th><input type="text" class="filter" data-column_num="9" placeholder="Available enumeration" style="width:95%"/></th>
>+            <th id="itemtype-filter"></th>
>+            <th id="locationfilter"></th>
>+            <th></th>
>+            <th></th>
>+            <th></th>
>+            <th id="pickup-location"></th>
>+            <th></th>
>         </tr>
>     </thead>
>     <tbody>
>@@ -251,27 +270,6 @@
>         </tr>
>         [% END %]
>     </tbody>
>-    <tfoot>
>-        <tr>
>-        <td><input type="text" class="filter" data-column_num="0" placeholder="Pull this many items" style="width:95%"/></td>
>-        <td><input type="text" class="filter" data-column_num="1" placeholder="Items available" style="width:95%"/></td>
>-        <td><input type="text" class="filter" data-column_num="2" placeholder="Patron holds" style="width:95%"/></td>
>-        <td><input type="text" class="filter" data-column_num="3" placeholder="Patron name" style="width:95%"/></td>
>-        <td><input type="text" class="filter" data-column_num="4" placeholder="Title" style="width:95%"/></td>
>-        <td id="homebranchfilter"></td>
>-        <td></td>
>-        <td><input type="text" class="filter" data-column_num="7" placeholder="Call number" style="width:95%"/></td>
>-        <td><input type="text" class="filter" data-column_num="8" placeholder="Available copy" style="width:95%"/></td>
>-        <td><input type="text" class="filter" data-column_num="9" placeholder="Available enumeration" style="width:95%"/></td>
>-        <td id="itemtype-filter"></td>
>-        <td id="locationfilter"></td>
>-        <td></td>
>-        <td></td>
>-        <td></td>
>-        <td id="pickup-location"></td>
>-        <td></td>
>-        </tr>
>-    </tfoot>
>     </table>
>     [% ELSE %]
>         <strong>No items found.</strong>
>@@ -324,11 +322,24 @@
> [% MACRO jsinclude BLOCK %]
>     [% INCLUDE 'calendar.inc' %]
>     [% INCLUDE 'datatables.inc' %]
>+    [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %]
>+    [% IF print %]
>+        <script>
>+            $( document ).ready(function() {
>+                window.print();
>+                window.onafterprint = function () {
>+                    window.close();
>+                }
>+                setTimeout('window.close()', 1000); // Hack for Chrome < 63
>+            });
>+        </script>
>+    [% END #/print %]
>     [% INCLUDE 'columns_settings.inc' %]
>     <script>
>         $(document).ready(function() {
>           var table_settings = [% TablesSettings.GetTableSettings('circ', 'holds', 'holds-to-pull', 'json') | $raw %];
>           var holdst = KohaTable("holdst", {
>+            "orderCellsTop":  true,
>             "pagingType": "full_numbers"
>           }, table_settings);
>           holdst.fnAddFilters("filter");
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37148: 168175 | 170759 | 170955 | 172279 | 172280 | 173272