Attachment 172328 Details for Bug 17976 – Bug 17976: Update test to include fines

[patch] Bug 17976: Update test to include fines

Bug-17976-Update-test-to-include-fines.patch (text/plain), 2.24 KB, created by Kyle M Hall (khall) on 2024-10-02 18:35:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-10-02 18:35:55 UTC

Size: 2.24 KB

patch

obsolete

>From 365327b1794305192c203b6e823a307bf44070a7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 1 Oct 2024 15:53:11 +0100
>Subject: [PATCH] Bug 17976: Update test to include fines
>
>This patch updates the existing test to include checking the alternative
>to items.fine syntax.
>
>We could use the account_lines relation, however that would include
>other charges linked to the checkout, for example rental charges.
>
>I opt to add a new accessor to give us more options and refine to just
>overdue fines.
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Letters/TemplateToolkit.t | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t
>index 1ac70733b14..35c836a97c4 100755
>--- a/t/db_dependent/Letters/TemplateToolkit.t
>+++ b/t/db_dependent/Letters/TemplateToolkit.t
>@@ -839,7 +839,7 @@ If you have registered a password with the library, and you have a renewal avail
> 
> The following item(s) is/are currently overdue:
> 
>-<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>></item>
>+<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>>, Fine: <<items.fine>></item>
> 
> <<items.content>>
> 
>@@ -889,6 +889,7 @@ EOF
> 
>         # historic syntax
>         my $tt_template = <<EOF;
>+[%- USE Price -%]
> Dear [% borrower.firstname %] [% borrower.surname %],
> 
> According to our current records, you have items that are overdue.Your library does not charge late fines, but please return or renew them at the branch below as soon as possible.
>@@ -906,7 +907,7 @@ The following item(s) is/are currently overdue:
> 
> [% FOREACH overdue IN overdues %]
> [%~ SET item = overdue.item ~%]
>-"[% item.biblio.title %]" by [% item.biblio.author %], [% item.itemcallnumber %], Barcode: [% item.barcode %]
>+"[% item.biblio.title %]" by [% item.biblio.author %], [% item.itemcallnumber %], Barcode: [% item.barcode %], Fine: [% overdue.overdue_fines.total_outstanding | \$Price %]
> [% END %]
> [% FOREACH overdue IN overdues %]
> [%~ SET item = overdue.item ~%]
>-- 
>2.39.5 (Apple Git-154)

Actions: View | Diff | Splinter Review

Attachments on bug 17976: 172277 | 172278 | 172283 | 172304 | 172305 | 172306 | 172328 | 172329 | 172330 | 172331 | 174324