Bugzilla – Attachment 17240 Details for
Bug 8061
Koha's templates do not cope well with right-to-left languages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8061: Follow up - RTL CSS overrides (staff client)
Bug-8061-Follow-up---RTL-CSS-overrides-staff-clien.patch (text/plain), 6.58 KB, created by
Chris Cormack
on 2013-04-07 08:51:38 UTC
(
hide
)
Description:
Bug 8061: Follow up - RTL CSS overrides (staff client)
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-04-07 08:51:38 UTC
Size:
6.58 KB
patch
obsolete
>From 310d98e92fbf8f2a358841189505edf86226b800 Mon Sep 17 00:00:00 2001 >From: Karam Qubsi <karamqubsi@gmail.com> >Date: Fri, 5 Apr 2013 13:07:43 +0300 >Subject: [PATCH] Bug 8061: Follow up - RTL CSS overrides (staff client) > >I think this patch is good for th rtl langs. >and based on what D.Ruth send before, I added some edits >as a right to left reader. > >Tested on master with Arabic >I used the updated po files for v. 3.8 (because the 3.12 ) >need some revision ... > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > koha-tmpl/opac-tmpl/prog/en/css/opac.css | 8 +++ > koha-tmpl/opac-tmpl/prog/en/css/right-to-left.css | 63 ++++++++++++++++++-- > .../opac-tmpl/prog/en/includes/opac-bottom.inc | 8 +-- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 3 + > 4 files changed, 73 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css >index cada641..c081075 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css >+++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css >@@ -1682,6 +1682,10 @@ ul#i18nMenu li.more ul li a { > background-image : none; > padding: 0 1.3em; > } >+.morelang, >+li.more { >+float:left >+} > > span.lang{ > float:left; >@@ -2938,3 +2942,7 @@ a.reviewlink,a.reviewlink:visited { > .branch-info-tooltip { > display: none; > } >+.lang { >+float:left; >+padding: 0.1em 0; >+} >diff --git a/koha-tmpl/opac-tmpl/prog/en/css/right-to-left.css b/koha-tmpl/opac-tmpl/prog/en/css/right-to-left.css >index 141fcc8..57a2cfd 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/css/right-to-left.css >+++ b/koha-tmpl/opac-tmpl/prog/en/css/right-to-left.css >@@ -24,6 +24,7 @@ table#marc th > > /* Swap floats */ > >+ > body#advsearch #cartmenulink, > body#advsearch #listsmenulink, > #renewcontrols, >@@ -35,7 +36,7 @@ body#advsearch #listsmenulink, > { > float: left; > } >- >+.ui-tabs .ui-tabs-nav li, > div.lang, > fieldset.rows label, > fieldset.rows span.label, >@@ -95,10 +96,6 @@ h6 > margin-left: 0.5em; > } > >-ul li >-{ >- margin-right: 1.5em; >-} > > ul.pg_menu li, > .author, >@@ -182,3 +179,59 @@ h3 img { > filter: FlipH; > -ms-filter: "FlipH"; > } >+ >+ >+#moresearches { >+ clear: right; >+} >+ >+#cartmenulink, #listsmenulink { >+ float: right; >+ margin-right: 1em; >+ margin-left: 0em; >+} >+ >+#listsmenulink { >+ >+ background-image: url("../../images/sprite.png"), -moz-linear-gradient(center top , rgb(215, 229, 255) 0%, rgb(177, 203, 255) 50%, rgb(159, 191, 255) 100%); >+ >+ background-position: -5px -287px, left top; >+ >+ padding-left: 20px; >+} >+#listsmenulink:hover { >+ background-position: -5px -287px, left top; >+} >+ >+#cartmenulink { >+ padding-right: 30px; >+ background-position: 20px -256px, left top; >+ padding-left: 13px; >+} >+#cartmenulink:hover { >+ background-position: 20px -256px, left top; >+} >+.lang { >+float:right; >+ >+} >+.morelang, >+li.more { >+float:right; >+} >+ >+ul#i18nMenu li { >+ border-right: 1px solid rgb(204, 204, 204); >+} >+div.rating-cancel, div.star-rating { >+ float: right; >+} >+ >+ >+#shelfbrowser #browser_previous { >+ background-position: -9px -1051px; >+} >+ >+#shelfbrowser #browser_next { >+ background-position: -9px -1001px; >+} >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc >index b7495f9..7020673 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc >@@ -9,13 +9,13 @@ > [% IF ( languages_loop && opaclanguagesdisplay ) %] > [% UNLESS ( one_language_enabled ) %] > <div id="changelanguage" class="ft"> >- <div class="lang" style="float:left;padding: 0.1em 0;"><strong>Languages: </strong></div> >+ <div class="lang"><strong>Languages: </strong></div> > <ul id="i18nMenu" class="footermenu"> > [% FOREACH languages_loo IN languages_loop %] > > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.plural ) %] >- <li class="more" style="float:left;"><a class="sublangs" id="show[% languages_loo.rfc4646_subtag %]" href="#">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a><div id="sub[% languages_loo.rfc4646_subtag %]"> >+ <li class="more"><a class="sublangs" id="show[% languages_loo.rfc4646_subtag %]" href="#">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a><div id="sub[% languages_loo.rfc4646_subtag %]"> > <div class="bd"><ul> > [% FOREACH sublanguages_loo IN languages_loo.sublanguages_loop %] > [% IF ( sublanguages_loo.enabled ) %] >@@ -32,9 +32,9 @@ > [% ELSE %] > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.current ) %] >- <li style="float:left;">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</li> >+ <li class="morelang">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</li> > [% ELSE %] >- <li style="float:left;"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li> >+ <li class="morelang"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li> > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index afe92c7..3c37bd1 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -17,6 +17,9 @@ > <link rel="stylesheet" type="text/css" href="/opac-tmpl/prog/en/css/jquery.rating.css" />[% END %] > > [% IF ( OpacHighlightedWords ) %]<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.highlight-3.js"></script>[% END %] >+[% IF ( bidi ) %] >+ <link rel="stylesheet" type="text/css" href="[% themelang %]/css/right-to-left.css" /> >+[% END %] > <script type="text/javascript"> > //<![CDATA[ > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8061
:
9470
|
9579
|
13087
|
17178
|
17206
|
17207
|
17215
|
17216
|
17231
|
17232
|
17233
|
17234
|
17235
|
17236
|
17237
|
17238
|
17239
|
17240
|
17241
|
17242
|
17243
|
17244
|
17245
|
17246
|
17247
|
17248
|
17249
|
17286