Bugzilla – Attachment 172420 Details for
Bug 13945
Multiple dialogs for item that needs transferred and hold captured at checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin
Bug-13945-Prevent-multiple-dialog-modals-from-popp.patch (text/plain), 2.42 KB, created by
Kyle M Hall (khall)
on 2024-10-04 16:43:11 UTC
(
hide
)
Description:
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-10-04 16:43:11 UTC
Size:
2.42 KB
patch
obsolete
>From a2888e1292706be4a3a24bc099c23cdebaefde5e Mon Sep 17 00:00:00 2001 >From: Laura Escamilla <laura.escamilla@bywatersolutions.com> >Date: Wed, 15 May 2024 15:34:22 +0000 >Subject: [PATCH] Bug 13945: Prevent multiple dialog modals from popping up > when capturing a hold at checkin > >1. Select/Create Library Branches: > - Select or create two library branches: Library A and Library B. > >2. Locate/Create Item: > - Locate or create an item with the "Current library" and "Home library" set to Library A. > >3. Place Hold: > - Place a hold on the item for a patron whose pickup location is Library B. > >4. Check-in at Library A - First Attempt: > - Check in the item at Library A. > - Verify that the 'Hold found' modal pops up. > - Click on 'Confirm hold and transfer'. > >5. Check-in at Library A - Second Attempt: > - Check in the item at Library A again. > - Verify that the 'Hold found' modal pops up. > - Click on 'Ignore'. > - Verify that the 'Please return this item to (Library B)' modal has popped up behind it. > >6. Apply Patch and Restart: > - Apply the patch to the system. > - Restart all relevant services. > >7. Repeat Check-in Process: > - Repeat steps 4 and 5. > - Verify that no matter how many times you check in the item and hit 'Ignore' or 'Confirm the hold', the second modal does not pop up. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 6c132ef2b8b..875ac47c0d9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -739,7 +739,7 @@ > </div> <!-- /#hold-found1 --> > [% END # /IF waiting %] > >- [% IF transfer || needstransfer %] >+ [% IF (transfer || needstransfer) && !(reserved and !recalled and !waitingrecall) %] > [% IF Koha.Preference('TransfersBlockCirc') %] > <div id="item-transfer-modal" class="modal modal-lg block audio-alert-action" data-bs-backdrop="static" data-bs-keyboard="false"> > [% ELSE %] >-- >2.39.5 (Apple Git-154)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13945
:
37440
|
166785
|
166801
| 172420