Attachment 172422 Details for Bug 38089 – Bug 38089: (QA follow-up) Ensure style works on members/printslip.pl

[patch] Bug 38089: (QA follow-up) Ensure style works on members/printslip.pl

Bug-38089-QA-follow-up-Ensure-style-works-on-membe.patch (text/plain), 1.75 KB, created by Nick Clemens (kidclamp) on 2024-10-04 16:50:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-10-04 16:50:01 UTC

Size: 1.75 KB

patch

obsolete

>From 5f1fcd593dc3389dab9c54783554aff89905f739 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 4 Oct 2024 16:43:44 +0000
>Subject: [PATCH] Bug 38089: (QA follow-up) Ensure style works on
> members/printslip.pl
>
>When moving the style up, it was moved before the code that handles printing a single slip, i.e.
>taking the variables and forming a slip hash.
>
>This patch moves that code to the top and additionally passes through the CODE of the notice so the ID is not blank
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt | 3 +++
> members/printslip.pl                                      | 1 +
> 2 files changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
>index 938c52f41e2..31405943b3a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
>@@ -3,6 +3,9 @@
> [% USE Koha %]
> [% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
>+[% UNLESS slips && slips.size %]
>+    [% SET slips = [{content => slip, is_html => !plain, style => style, id => id }] %]
>+[% END %]
> <title>[% FILTER collapse %]
> [% IF ( caller == 'hold-transfer' ) %]
>     [% t("Hold transfer print receipt") | html %] &rsaquo;
>diff --git a/members/printslip.pl b/members/printslip.pl
>index 67df3fd808b..9cf130c22fd 100755
>--- a/members/printslip.pl
>+++ b/members/printslip.pl
>@@ -120,6 +120,7 @@ $template->param(
>     stylesheet     => C4::Context->preference("SlipCSS"),
>     error          => $error,
>     style          => $letter->{style},
>+    id             => $print,
> );
> 
> $template->param( IntranetSlipPrinterJS => C4::Context->preference('IntranetSlipPrinterJS' ) );
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38089: 172380 | 172421 | 172422 | 172464 | 172465 | 172473