Attachment 172431 Details for Bug 38049 – Revert "Bug 37917: Add some wait time to RecordSources_spec.ts for the intercepted request responses"

[patch] Revert "Bug 37917: Add some wait time to RecordSources_spec.ts for the intercepted request responses"

Revert-Bug-37917-Add-some-wait-time-to-RecordSourc.patch (text/plain), 2.64 KB, created by David Nind on 2024-10-06 22:22:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-06 22:22:14 UTC

Size: 2.64 KB

patch

obsolete

>From ecc220ca7a928bf8167d40addfbd02fe97c0f26e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 1 Oct 2024 11:40:56 +0200
>Subject: [PATCH] Revert "Bug 37917: Add some wait time to
> RecordSources_spec.ts for the intercepted request responses"
>
>This reverts commit 23b00bdc06d28e012724a37ed5052bf056026302.
>
>JD: No, really, don't wait.
>And it does not fix the issue initially raised on bug 37917
>
>https://bugs.koha-community.org/show_bug.cgi?id=38049
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/cypress/integration/Admin/RecordSources_spec.ts | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/t/cypress/integration/Admin/RecordSources_spec.ts b/t/cypress/integration/Admin/RecordSources_spec.ts
>index 09c2c40525..90f13afc8e 100644
>--- a/t/cypress/integration/Admin/RecordSources_spec.ts
>+++ b/t/cypress/integration/Admin/RecordSources_spec.ts
>@@ -31,7 +31,6 @@ describe("Record sources CRUD tests", () => {
> 
>     it("Add", () => {
>         cy.visit("/cgi-bin/koha/admin/admin-home.pl");
>-        cy.wait(500);
>         cy.contains("Record sources").click();
>         cy.contains("New record source").click();
>         cy.get("#name").type("Poop");
>@@ -58,7 +57,6 @@ describe("Record sources CRUD tests", () => {
>             },
>         });
>         cy.visit("/cgi-bin/koha/admin/record_sources");
>-        cy.wait(500);
>         cy.get("#record_sources_list").contains(
>             "There are no record sources defined"
>         );
>@@ -91,7 +89,6 @@ describe("Record sources CRUD tests", () => {
>             },
>         });
>         cy.visit("/cgi-bin/koha/admin/record_sources");
>-        cy.wait(500);
>         cy.get("#record_sources_list").contains("Showing 1 to 3 of 3 entries");
> 
>         cy.get(".dataTable > tbody > tr:first-child").within(() => {
>@@ -154,7 +151,6 @@ describe("Record sources CRUD tests", () => {
>                 can_be_edited: true,
>             },
>         });
>-        cy.wait(500);
>         cy.get("#record_sources_list table tbody tr:first")
>             .contains("Edit")
>             .click();
>@@ -170,7 +166,6 @@ describe("Record sources CRUD tests", () => {
>             },
>         });
>         cy.visit("/cgi-bin/koha/admin/record_sources/edit/1");
>-        cy.wait(500);
>         cy.get("#name").should("have.value", "Source 1");
>         cy.get("#can_be_edited").should("not.be.checked");
> 
>@@ -215,7 +210,6 @@ describe("Record sources CRUD tests", () => {
>             },
>         });
>         cy.visit("/cgi-bin/koha/admin/record_sources");
>-        cy.wait(500);
>         cy.intercept("DELETE", "/api/v1/record_sources/2", {
>             statusCode: 204,
>             body: {},
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38049: 172250 | 172251 | 172259 | 172260 | 172431 | 172432 | 172433 | 172510 | 172511 | 172512