Bugzilla – Attachment 172437 Details for
Bug 28907
Potential unauthorized access in public REST routes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28907: REST - Remove allow-owner from public checkouts route
Bug-28907-REST---Remove-allow-owner-from-public-ch.patch (text/plain), 3.15 KB, created by
Victor Grousset/tuxayo
on 2024-10-07 01:06:38 UTC
(
hide
)
Description:
Bug 28907: REST - Remove allow-owner from public checkouts route
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-10-07 01:06:38 UTC
Size:
3.15 KB
patch
obsolete
>From 043ca7e39f8e4b00e7196783a3d645b1e033628f Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Wed, 18 Sep 2024 08:44:46 +0000 >Subject: [PATCH] Bug 28907: REST - Remove allow-owner from public checkouts > route > >To test: >1. prove t/db_dependent/api/v1/checkouts.t >2. Apply patch >3. prove t/db_dependent/api/v1/checkouts.t > >Observe success in both cases. > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > Koha/REST/V1/Checkouts.pm | 25 ++++++++++++------------ > api/v1/swagger/paths/public_patrons.yaml | 2 -- > t/db_dependent/api/v1/checkouts.t | 3 +-- > 3 files changed, 14 insertions(+), 16 deletions(-) > >diff --git a/Koha/REST/V1/Checkouts.pm b/Koha/REST/V1/Checkouts.pm >index 301369a45c..793453613e 100644 >--- a/Koha/REST/V1/Checkouts.pm >+++ b/Koha/REST/V1/Checkouts.pm >@@ -27,6 +27,7 @@ use Koha::Checkouts; > use Koha::Old::Checkouts; > use Koha::Token; > >+use Scalar::Util qw( blessed ); > use Try::Tiny qw( catch try ); > > =head1 NAME >@@ -190,19 +191,19 @@ sub add { > my $patron_id = $body->{patron_id}; > my $onsite = $body->{onsite_checkout}; > >- if ( $c->stash('is_public') >- && !C4::Context->preference('OpacTrustedCheckout') ) >- { >- return $c->render( >- status => 405, >- openapi => { >- error => 'Feature disabled', >- error_code => 'FEATURE_DISABLED' >- } >- ); >- } >- > return try { >+ if ( $c->stash('is_public') ) { >+ $c->auth->public($patron_id); >+ >+ return $c->render( >+ status => 405, >+ openapi => { >+ error => 'Feature disabled', >+ error_code => 'FEATURE_DISABLED' >+ } >+ ) if !C4::Context->preference('OpacTrustedCheckout'); >+ } >+ > my $item = Koha::Items->find($item_id); > unless ($item) { > return $c->render( >diff --git a/api/v1/swagger/paths/public_patrons.yaml b/api/v1/swagger/paths/public_patrons.yaml >index 9a987ee0ed..0d1e48c6ca 100644 >--- a/api/v1/swagger/paths/public_patrons.yaml >+++ b/api/v1/swagger/paths/public_patrons.yaml >@@ -130,8 +130,6 @@ > description: Under maintenance > schema: > $ref: "../swagger.yaml#/definitions/error" >- x-koha-authorization: >- allow-owner: true > "/public/patrons/{patron_id}/guarantors/can_see_charges": > put: > x-mojo-to: Patrons#guarantors_can_see_charges >diff --git a/t/db_dependent/api/v1/checkouts.t b/t/db_dependent/api/v1/checkouts.t >index 8f306df0e0..24ad12c38b 100755 >--- a/t/db_dependent/api/v1/checkouts.t >+++ b/t/db_dependent/api/v1/checkouts.t >@@ -536,8 +536,7 @@ subtest 'add checkout' => sub { > $t->post_ok( "//$userid:$password@/api/v1/public/patrons/$patron_id/checkouts" => json => > { item_id => $item1_id, patron_id => $patron_id } )->status_is(403)->json_is( > { >- error => "Authorization failure. Missing required permission(s).", >- required_permissions => undef >+ error => "Unprivileged user cannot access another user's resources" > } > ); > >-- >2.46.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28907
:
171666
|
171667
|
171668
|
171669
|
171670
|
171671
|
171672
|
171673
|
171674
|
172434
|
172435
|
172436
|
172437
|
172438
|
172439
|
172440
|
172441
|
172442
|
174662
|
174663
|
174664
|
174665
|
174666
|
174667
|
174668
|
174669
|
174670
|
176708
|
176709
|
176710
|
176711
|
176712
|
176713
|
176714
|
176715
|
176716
|
177679
|
177680
|
177681
|
177682
|
177683
|
177684
|
177685
|
177686
|
177687
|
179000