Bugzilla – Attachment 172473 Details for
Bug 38089
Fix incorrect regular expression from bug 33478 and move styles to head
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38089: (follow-up) More fixes for errors in original submission
Bug-38089-follow-up-More-fixes-for-errors-in-origi.patch (text/plain), 3.56 KB, created by
Martin Renvoize (ashimema)
on 2024-10-07 14:28:25 UTC
(
hide
)
Description:
Bug 38089: (follow-up) More fixes for errors in original submission
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-07 14:28:25 UTC
Size:
3.56 KB
patch
obsolete
>From 7767b424f131a9b45c6c973d2067f59d328b8cb4 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 7 Oct 2024 15:26:35 +0100 >Subject: [PATCH] Bug 38089: (follow-up) More fixes for errors in original > submission > >The original submission missed a number of slip types that are print on >demand without queueing. > >These all need an "id" passing in to the template and in some cases we >were also missing passing in the new style parameter too (preservation) >--- > circ/article-request-slip.pl | 1 + > circ/hold-transfer-slip.pl | 1 + > circ/transfer-slip.pl | 1 + > members/print_overdues.pl | 1 + > preservation/print_slip.pl | 3 +++ > recalls/recall_pickup_slip.pl | 1 + > 6 files changed, 8 insertions(+) > >diff --git a/circ/article-request-slip.pl b/circ/article-request-slip.pl >index 5ab59576c9a..ed8bf8aa4ec 100755 >--- a/circ/article-request-slip.pl >+++ b/circ/article-request-slip.pl >@@ -81,6 +81,7 @@ $template->param( > caller => 'article-request', > plain => 0, > style => $style, >+ id => 'ar_slip', > ); > > output_html_with_http_headers $cgi, $cookie, $template->output; >diff --git a/circ/hold-transfer-slip.pl b/circ/hold-transfer-slip.pl >index 435d1c14e08..dab16202d05 100755 >--- a/circ/hold-transfer-slip.pl >+++ b/circ/hold-transfer-slip.pl >@@ -54,6 +54,7 @@ $template->param( slip => $slip ) if ($slip); > $template->param( caller => 'hold-transfer' ); > $template->param( plain => !$is_html ); > $template->param( style => $style ); >+$template->param( id => 'reserve_slip' ); > > output_html_with_http_headers $input, $cookie, $template->output; > >diff --git a/circ/transfer-slip.pl b/circ/transfer-slip.pl >index 5282bbe44eb..b8f8a5031fe 100755 >--- a/circ/transfer-slip.pl >+++ b/circ/transfer-slip.pl >@@ -60,6 +60,7 @@ $template->param( > caller => 'cud-transfer', > stylesheet => C4::Context->preference("SlipCSS"), > style => $style, >+ id => 'transfer_slip', > ); > > output_html_with_http_headers $input, $cookie, $template->output; >diff --git a/members/print_overdues.pl b/members/print_overdues.pl >index 135e1df39dc..d5bb612e156 100755 >--- a/members/print_overdues.pl >+++ b/members/print_overdues.pl >@@ -68,6 +68,7 @@ $template->param( > plain => !$letter->{is_html}, > borrowernumber => $borrowernumber, > style => $letter->{style}, >+ id => 'overdues_slip', > ); > > output_html_with_http_headers $input, $cookie, $template->output; >diff --git a/preservation/print_slip.pl b/preservation/print_slip.pl >index 285319e036d..153508c3d61 100755 >--- a/preservation/print_slip.pl >+++ b/preservation/print_slip.pl >@@ -40,6 +40,7 @@ my $logged_in_user = Koha::Patrons->find($loggedinuser); > my $branch = C4::Context->userenv->{'branch'}; > > my @slips; >+my $count = 0; > for my $train_item_id (@train_item_ids) { > my $train_item = Koha::Preservation::Train::Items->find($train_item_id); > my $letter = C4::Letters::GetPreparedLetter( >@@ -55,6 +56,8 @@ for my $train_item_id (@train_item_ids) { > push @slips, { > content => $letter->{content}, > is_html => $letter->{is_html}, >+ style => $letter->{style}, >+ id => ++$count, > }; > } > >diff --git a/recalls/recall_pickup_slip.pl b/recalls/recall_pickup_slip.pl >index 19e439ce29f..247e03686b4 100755 >--- a/recalls/recall_pickup_slip.pl >+++ b/recalls/recall_pickup_slip.pl >@@ -70,6 +70,7 @@ $template->param( > plain => !$is_html, > caller => 'recall', > style => $style, >+ id => 'recall_request_det', > ); > > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.46.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38089
:
172380
|
172421
|
172422
|
172464
|
172465
| 172473