Attachment 172511 Details for Bug 38049 – Bug 38049: Remove tooltip call from DT

[patch] Bug 38049: Remove tooltip call from DT

Bug-38049-Remove-tooltip-call-from-DT.patch (text/plain), 2.55 KB, created by Pedro Amorim on 2024-10-08 08:12:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-08 08:12:09 UTC

Size: 2.55 KB

patch

obsolete

>From af96c732734b3e2968954f58bca947cb79fa74f2 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 1 Oct 2024 11:42:07 +0200
>Subject: [PATCH] Bug 38049: Remove tooltip call from DT
>
>Not really sure why we had this line, but Owen decided to remove it when
>upgrading to Bootstrap5.
>
>So let's remove them from the other files as well.
>
>Waiting for Owen to confirm this one.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 2 --
> koha-tmpl/intranet-tmpl/prog/js/datatables.js                 | 2 --
> koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue  | 4 ----
> 3 files changed, 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
>index 3da3511cf12..9bb0f982ba0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
>@@ -230,8 +230,6 @@ function KohaTable(id_selector, dt_parameters, table_settings, add_filters) {
>         deactivate_filters(id_selector);
>     }
> 
>-    $(".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table").tooltip();
>-
>     return table;
> }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index 5e319843062..576a9233983 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -979,8 +979,6 @@ function _dt_add_delay(table_dt, table_node, delay_ms) {
> 
>         settings["buttons"] = _dt_buttons({included_ids, settings, table_settings});
> 
>-        // $(".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table").tooltip();
>-
>         if ( add_filters ) {
>             settings['orderCellsTop'] = true;
>         }
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
>index d3a03bd9743..0f35a2cab8e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
>@@ -135,10 +135,6 @@ export default {
>             ]
>         }
> 
>-        $(
>-            ".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table"
>-        ).tooltip()
>-
>         if (this.add_filters) {
>             this.options.orderCellsTop = true
>         }
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38049: 172250 | 172251 | 172259 | 172260 | 172431 | 172432 | 172433 | 172510 | 172511 | 172512