Attachment 172512 Details for Bug 38049 – Bug 38049: Call .tooltip() only if needed

[patch] Bug 38049: Call .tooltip() only if needed

Bug-38049-Call-tooltip-only-if-needed.patch (text/plain), 1.24 KB, created by Pedro Amorim on 2024-10-08 08:12:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-08 08:12:12 UTC

Size: 1.24 KB

patch

obsolete

>From 896a8fb5fcc84943aa7b9812ea05635d9d6bc88c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 1 Oct 2024 14:15:07 +0200
>Subject: [PATCH] Bug 38049: Call .tooltip() only if needed
>
>This is cheating, yes.
>
>We had a cypress test failing because of this line
>  $(...).tooltip is not a function
>
>It's failing randomly on Admin/RecordSources_spec.ts, which does not
>need the tooltip.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>index cfb6769f0d7..1eb53b2f433 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>@@ -381,7 +381,10 @@ $(document).ready(function () {
>         $("#setlibrary_panel").removeClass("setlibrary_panel_open").html("").hide();
>     });
> 
>-    $('[data-bs-toggle="tooltip"]').tooltip();
>+    if ( $('[data-bs-toggle="tooltip"]').length ) {
>+        $('[data-bs-toggle="tooltip"]').tooltip();
>+    }
>+
> });
> 
> function removeLastBorrower() {
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38049: 172250 | 172251 | 172259 | 172260 | 172431 | 172432 | 172433 | 172510 | 172511 | 172512