Bugzilla – Attachment 17253 Details for
Bug 8770
amount does not equal amountoutstanding on a fine with no payments or credits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8770 - amount does not equal amountoutstanding on a fine with no payments or credits
PASSED-QA-Bug-8770---amount-does-not-equal-amounto.patch (text/plain), 2.54 KB, created by
Katrin Fischer
on 2013-04-07 12:11:48 UTC
(
hide
)
Description:
[PASSED QA] Bug 8770 - amount does not equal amountoutstanding on a fine with no payments or credits
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-04-07 12:11:48 UTC
Size:
2.54 KB
patch
obsolete
>From d53e13656620295a90654a34c6fdb32c9584bf09 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 3 Apr 2013 13:05:52 -0400 >Subject: [PATCH] [PASSED QA] Bug 8770 - amount does not equal > amountoutstanding on a fine with no payments or credits > >If a lost item fee is owed and partially paid off when an item is >returned and a refund is processed, Koha tries to pay off existing >fees before adding any leftover balance as a credit on the account. > >However, those fee payments aren't actually processed, due to a bug >where the accountnumber was quoted as a string literal, and thus the >for the fee payment would fail. This did not result in an DB error, >as the query was still valid SQL. Checking the return value of the >query would have revealed that the accountline had not been updated. > >History: >This bug was introduced on April 23, 2007 with the commit >'reintroducing fixaccountforlostandreturned as requested by rosalie'. >Commit id 111d590e9cdaf801256822e23f170bfc2365338f > >On July 30, 2009 the error was flagged with a FIXME and remained >in that state until now. >Commit id 51e8fc2cb6a0cf79f19206c822a4361aeca6f63f > >Test plan: >1) Create a test patron >2) Check out an item to that patron and give it a due date in the past >3) Run fines.pl to generate the fine for the item >4) Mark the item long overdue on the item tab (not in edit items) >5) Pay for the lost item >6) Check the item back in >7) Note the incorrect fines. Only the lost fee balance due is refunded, > not the entire lost fee, but no other fees are paid off. >8) Apply the patch >9) Repeat steps 1-6, then not the fines are paid correctly > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Totel due is correct after applying the patch. >All tests and QA script pass. >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index f3c5808..3fc124f 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2171,7 +2171,7 @@ sub _FixAccountForLostAndReturned { > # FIXME: move prepares outside while loop! > my $usth = $dbh->prepare("UPDATE accountlines SET amountoutstanding= ? > WHERE (accountlines_id = ?)"); >- $usth->execute($newamtos,'$thisacct'); # FIXME: '$thisacct' is a string literal! >+ $usth->execute($newamtos,$thisacct); > $usth = $dbh->prepare("INSERT INTO accountoffsets > (borrowernumber, accountno, offsetaccount, offsetamount) > VALUES >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8770
:
12201
|
12202
|
12203
|
12508
|
12509
|
12529
|
12530
|
17175
|
17220
| 17253