Attachment 172561 Details for Bug 37954 – Bug 37954: Fix barcode column name

[patch] Bug 37954: Fix barcode column name

Bug-37954-Fix-barcode-column-name.patch (text/plain), 1.58 KB, created by Martin Renvoize (ashimema) on 2024-10-09 08:35:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-09 08:35:45 UTC

Size: 1.58 KB

patch

obsolete

>From a36a75ba14c82d86d177e633db5c13ad68583e83 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Wed, 18 Sep 2024 10:22:51 +0000
>Subject: [PATCH] Bug 37954: Fix barcode column name
>
>Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
>holdings_barcode to holdings_barcodes
>
>I believe this caused the configuration from the table to no longer
>work (barcodes!=barcode)
>
>Test plan:
>1) Access any bibllio:
>   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
>2) On the top right of the table, click 'Configure'
>3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
>   default'. Save.
>4) Visit the biblio again, notice the column is still showing.
>5) Apply patch. Restart all + flush_memcached. Repeat.
>6) Bonus: On the table, click 'Show filters'. Make sure barcode
>   filtering still works.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> admin/columns_settings.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
>index 82548ed2c56..f911f099c37 100644
>--- a/admin/columns_settings.yml
>+++ b/admin/columns_settings.yml
>@@ -411,7 +411,7 @@ modules:
>             -
>               columnname: holdings_datelastborrowed
>             -
>-              columnname: holdings_barcodes
>+              columnname: holdings_barcode
>             -
>               columnname: holdings_uri
>             -
>-- 
>2.46.2

Actions: View | Diff | Splinter Review

Attachments on bug 37954: 171659 | 171662 | 171698 | 171713 | 171714 | 172561 | 172562 | 172563 | 172564