Attachment 172624 Details for Bug 10190 – Bug 10190: Rename 'All *' to 'Default rule for *'

[patch] Bug 10190: Rename 'All *' to 'Default rule for *'

Bug-10190-Rename-All--to-Default-rule-for-.patch (text/plain), 3.65 KB, created by Martin Renvoize (ashimema) on 2024-10-10 14:41:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-10 14:41:01 UTC

Size: 3.65 KB

patch

obsolete

>From 719921332b3f37607ab3ecff681fe9fbb5d74763 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 9 Oct 2024 17:02:19 +0100
>Subject: [PATCH] Bug 10190: Rename 'All *' to 'Default rule for *'
>
>Try to clarify that the 'All' rules are actually fallback/default rules
>for when there's not a more specific rule for the context.
>
>We need to expose these clearly for each 'Library' view too which we're
>not currently doing.
>---
> .../CirculationTriggers/CirculationTriggersFormAdd.vue      | 6 +++---
> .../Admin/CirculationTriggers/CirculationTriggersList.vue   | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue
>index 02d87716d59..b624484def2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue
>@@ -421,7 +421,7 @@ export default {
>                 libraries => {
>                     libraries.unshift({
>                         library_id: "*",
>-                        name: "All libraries",
>+                        name: "Default rule for all libraries",
>                     })
>                     this.libraries = libraries
>                 },
>@@ -434,7 +434,7 @@ export default {
>                 categories => {
>                     categories.unshift({
>                         patron_category_id: "*",
>-                        name: "All categories",
>+                        name: "Default rule for all categories",
>                     })
>                     this.categories = categories
>                 },
>@@ -447,7 +447,7 @@ export default {
>                 types => {
>                     types.unshift({
>                         item_type_id: "*",
>-                        description: "All item types",
>+                        description: "Default rule for all item types",
>                     })
>                     this.itemTypes = types
>                 },
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue
>index cdc2c5a4f2a..bc276972680 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue
>@@ -168,7 +168,7 @@ export default {
>                 libraries => {
>                     libraries.unshift({
>                         library_id: "*",
>-                        name: "All libraries",
>+                        name: "Default rules for all libraries",
>                     })
>                     this.libraries = libraries
>                 },
>@@ -181,7 +181,7 @@ export default {
>                 categories => {
>                     categories.unshift({
>                         patron_category_id: "*",
>-                        name: "All",
>+                        name: "Default rule",
>                     })
>                     this.categories = categories
>                 },
>@@ -194,7 +194,7 @@ export default {
>                 types => {
>                     types.unshift({
>                         item_type_id: "*",
>-                        description: "All",
>+                        description: "Default rule",
>                     })
>                     this.itemTypes = types
>                 },
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 10190: 170357 | 170358 | 170359 | 170360 | 170361 | 170362 | 170363 | 170364 | 170365 | 170366 | 170367 | 170368 | 170369 | 170370 | 170371 | 170372 | 170373 | 170374 | 170375 | 170376 | 170380 | 170449 | 171727 | 171728 | 171729 | 171730 | 171731 | 171732 | 171733 | 171734 | 171735 | 171736 | 171737 | 171738 | 171739 | 171740 | 171741 | 171742 | 171743 | 171744 | 171745 | 171746 | 171747 | 171748 | 171749 | 171750 | 171751 | 171752 | 171753 | 171754 | 171755 | 172588 | 172589 | 172590 | 172591 | 172592 | 172593 | 172594 | 172595 | 172596 | 172597 | 172598 | 172599 | 172600 | 172601 | 172602 | 172603 | 172604 | 172605 | 172606 | 172607 | 172608 | 172609 | 172612 | 172614 | 172617 | 172619 | 172621 | 172622 | 172623 | 172624 | 172625 | 172626 | 172630 | 172631 | 172632 | 172633 | 172634 | 172635 | 172636 | 172637 | 172638 | 172639 | 172640 | 172641 | 172642 | 172643 | 172644 | 172645 | 172646 | 172647 | 172648 | 172649 | 172650 | 172651 | 172652 | 172653 | 172654 | 172655 | 172656 | 172657 | 172658 | 172659 | 172660 | 172661 | 172662 | 172663