Attachment 172646 Details for Bug 10190 – Bug 10190: Set tab based on trigger edited/created

[patch] Bug 10190: Set tab based on trigger edited/created

Bug-10190-Set-tab-based-on-trigger-editedcreated.patch (text/plain), 3.04 KB, created by Martin Renvoize (ashimema) on 2024-10-10 16:20:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-10 16:20:29 UTC

Size: 3.04 KB

patch

obsolete

>From ae5d83ddd926d2a4cd065346171afe2ab5dce839 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 14 Aug 2024 15:08:31 +0000
>Subject: [PATCH] Bug 10190: Set tab based on trigger edited/created
>
>Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
>Signed-off-by: George Harkins <George.Harkins@cityofglasgowcollege.ac.uk>
>---
> .../CirculationTriggersFormAdd.vue            |  5 ++++-
> .../CirculationTriggersList.vue               | 19 +++++++++----------
> 2 files changed, 13 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue
>index fac7b534fc3..45849640e9c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersFormAdd.vue
>@@ -306,7 +306,10 @@ export default {
>             await client.circRules.update(circRule).then(
>                 () => {
>                     this.$router
>-                        .push({ name: "CirculationTriggersList" })
>+                        .push({
>+                            name: "CirculationTriggersList",
>+                            query: { trigger: this.newTriggerNumber },
>+                        })
>                         .then(() => this.$router.go(0))
>                 },
>                 error => {}
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue
>index 27c0511c8a5..ac339cfe939 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/CirculationTriggersList.vue
>@@ -141,17 +141,16 @@ export default {
>     beforeRouteEnter(to, from, next) {
>         next(vm => {
>             vm.getLibraries().then(() =>
>-                vm
>-                    .getCategories()
>-                    .then(() =>
>-                        vm
>-                            .getItemTypes()
>-                            .then(() =>
>-                                vm
>-                                    .getCircRules({}, true)
>-                                    .then(() => (vm.initialized = true))
>-                            )
>+                vm.getCategories().then(() =>
>+                    vm.getItemTypes().then(() =>
>+                        vm.getCircRules({}, true).then(() => {
>+                            vm.tabSelected = to.query.trigger
>+                                ? `Notice ${to.query.trigger}`
>+                                : "Notice 1"
>+                            vm.initialized = true
>+                        })
>                     )
>+                )
>             )
>         })
>     },
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 10190: 170357 | 170358 | 170359 | 170360 | 170361 | 170362 | 170363 | 170364 | 170365 | 170366 | 170367 | 170368 | 170369 | 170370 | 170371 | 170372 | 170373 | 170374 | 170375 | 170376 | 170380 | 170449 | 171727 | 171728 | 171729 | 171730 | 171731 | 171732 | 171733 | 171734 | 171735 | 171736 | 171737 | 171738 | 171739 | 171740 | 171741 | 171742 | 171743 | 171744 | 171745 | 171746 | 171747 | 171748 | 171749 | 171750 | 171751 | 171752 | 171753 | 171754 | 171755 | 172588 | 172589 | 172590 | 172591 | 172592 | 172593 | 172594 | 172595 | 172596 | 172597 | 172598 | 172599 | 172600 | 172601 | 172602 | 172603 | 172604 | 172605 | 172606 | 172607 | 172608 | 172609 | 172612 | 172614 | 172617 | 172619 | 172621 | 172622 | 172623 | 172624 | 172625 | 172626 | 172630 | 172631 | 172632 | 172633 | 172634 | 172635 | 172636 | 172637 | 172638 | 172639 | 172640 | 172641 | 172642 | 172643 | 172644 | 172645 | 172646 | 172647 | 172648 | 172649 | 172650 | 172651 | 172652 | 172653 | 172654 | 172655 | 172656 | 172657 | 172658 | 172659 | 172660 | 172661 | 172662 | 172663