Attachment 172665 Details for Bug 38129 – Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal

[patch] Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal

Bug-38129-Display-note-regarding-permissions-in-su.patch (text/plain), 3.08 KB, created by Lucas Gass (lukeg) on 2024-10-10 16:28:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-10-10 16:28:49 UTC

Size: 3.08 KB

patch

obsolete

>From 898b5e6c0ed4eedd2d425b34f0d8da0bf39aeb42 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 9 Oct 2024 09:35:27 +0200
>Subject: [PATCH] Bug 38129: Display note regarding permissions in suggestion
> manager search pop-up modal
>
>1. In the staff interface, go to More > Suggestions > New purchase
>   suggestion
>2. Click 'Select manager'
>   => With this patch you see a note regarding permissions
>3. Search for 'alford' (for example)
>   => User is not returned, they do not have the suggestion permission
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt  | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index e342ee6cf08..c8b2841a0d9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -1536,13 +1536,15 @@
>     [% IF op == 'save' %]
>         [% PROCESS patron_search_modal columns => columns, modal_title => t("Select suggester"), patron_search_modal_id => 'patron_search_modal_suggester', table_id => 'patron_search_modal_suggester_table' %]
>         [% PROCESS patron_search_js columns => columns, actions => ["select"], preview_on_name_click => 1, table_id => 'patron_search_modal_suggester_table', callback => 'select_suggester' %]
>+        [% SET filter = "suggestions_managers" %]
>         [% PROCESS patron_search_modal columns => columns, modal_title => t("Select manager"), patron_search_modal_id => 'patron_search_modal_manager', table_id => 'patron_search_modal_manager_table' %]
>-        [% PROCESS patron_search_js columns => columns, filter => 'suggestions_managers', actions => ["select"], preview_on_name_click => 1, table_id => 'patron_search_modal_manager_table', callback => 'select_manager' %]
>+        [% PROCESS patron_search_js columns => columns, actions => ["select"], preview_on_name_click => 1, table_id => 'patron_search_modal_manager_table', callback => 'select_manager' %]
>     [% ELSIF op == 'else' %]
>         [% FOREACH suggestion IN suggestions %]
>             <script>tab = [% loop.count | html %];</script>
>+            [% SET filter = "suggestions_managers" %]
>             [% PROCESS patron_search_modal columns => columns, modal_title => t("Select manager"), patron_search_modal_id => 'patron_search_modal_manager_' _ loop.count, table_id => 'patron_search_modal_manager_table_' _ loop.count %]
>-            [% PROCESS patron_search_js columns => columns, filter => 'suggestions_managers', actions => ["select"], preview_on_name_click => 1, table_id => 'patron_search_modal_manager_table_' _ loop.count, callback => 'select_manager' %]
>+            [% PROCESS patron_search_js columns => columns, actions => ["select"], preview_on_name_click => 1, table_id => 'patron_search_modal_manager_table_' _ loop.count, callback => 'select_manager' %]
>         [% END %]
>     [% END %]
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 38129: 172557 | 172571 | 172665