Attachment 172711 Details for Bug 38162 – Bug 38162: Pass the rota_id correctly when deleting

[patch] Bug 38162: Pass the rota_id correctly when deleting

Bug-38162-Pass-the-rotaid-correctly-when-deleting.patch (text/plain), 2.02 KB, created by Lucas Gass (lukeg) on 2024-10-12 14:29:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-10-12 14:29:58 UTC

Size: 2.02 KB

patch

obsolete

>From de7f0ed26dddc32190bc43da429b6807586cab55 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Sat, 12 Oct 2024 14:28:57 +0000
>Subject: [PATCH] Bug 38162: Pass the rota_id correctly when deleting
>
>To test:
>
>1. Enable StockRotation
>2. Got to Cataloging -> Stock rotation
>3. Create a new Rota
>4. Try to delete it
>5. See the error "Can't call method "delete" on an undefined value at /kohadevbox/koha/tools/stockrotation.pl line 231"
>6. APPLY PATCH
>7. Try again, the rota should be deleted properly.
>---
> .../intranet-tmpl/prog/en/modules/tools/stockrotation.tt      | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt
>index ddd072a55c9..de37867206a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt
>@@ -406,10 +406,10 @@
>                             [% END %]
>                         [% END %]
>                         <p>
>-                            <form id="delete_rota_[% rota.rota_id | html %]" method="post" action="/cgi-bin/koha/tools/stockrotation.pl">
>+                            <form id="delete_rota_[% rota_id | html %]" method="post" action="/cgi-bin/koha/tools/stockrotation.pl">
>                                 [% INCLUDE 'csrf-token.inc' %]
>                                 <input type="hidden" name="op" value="cud-delete_rota" />
>-                                <input type="hidden" name="rota_id" value="[% rota.rota_id | html %]" />
>+                                <input type="hidden" name="rota_id" value="[% rota_id | html %]" />
>                                 <button class="btn btn-default btn-xs approve" type="submit"><i class="fa fa-fw fa-check"></i> Yes</button>
>                             </form>
>                             <a class="btn btn-default btn-xs deny" href="/cgi-bin/koha/tools/stockrotation.pl"><i class="fa fa-fw fa-times"></i> No</a>
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 38162: 172711 | 172775 | 172794 | 172796