Bugzilla – Attachment 172732 Details for
Bug 35570
Add a generic master form in ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35570: (QA follow-up) Tidy
Bug-35570-QA-follow-up-Tidy.patch (text/plain), 2.67 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-10-14 14:38:29 UTC
(
hide
)
Description:
Bug 35570: (QA follow-up) Tidy
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-10-14 14:38:29 UTC
Size:
2.67 KB
patch
obsolete
>From ba610900a46a61b5993f67c18fbba41477b04e43 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 14 Oct 2024 10:51:27 -0300 >Subject: [PATCH] Bug 35570: (QA follow-up) Tidy > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Backend/Standard.pm | 17 +++++++++++++---- > Koha/ILL/Request.pm | 8 ++++---- > 2 files changed, 17 insertions(+), 8 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 5aba0eab1fa..62ecbe30264 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -25,7 +25,7 @@ use C4::Installer; > use Koha::DateUtils qw/ dt_from_string /; > use Koha::ILL::Requests; > use Koha::ILL::Request::Attribute; >-use C4::Biblio qw( AddBiblio ); >+use C4::Biblio qw( AddBiblio ); > use C4::Charset qw( MarcToUTF8Record ); > > =head1 NAME >@@ -1166,15 +1166,24 @@ sub _standard_request2biblio { > } > > if ($isbn) { >- my $marc_isbn = $marcflavour eq 'MARC21' ? MARC::Field->new( '020', '', '', a => $isbn ) : MARC::Field->new( '010', '', '', a => $isbn ); >+ my $marc_isbn = >+ $marcflavour eq 'MARC21' >+ ? MARC::Field->new( '020', '', '', a => $isbn ) >+ : MARC::Field->new( '010', '', '', a => $isbn ); > $record->append_fields($marc_isbn); > } > if ($author) { >- my $marc_author = $marcflavour eq 'MARC21' ? MARC::Field->new( '100', '1', '', a => $author ) : MARC::Field->new( '700', '1', '', a => $author ); >+ my $marc_author = >+ $marcflavour eq 'MARC21' >+ ? MARC::Field->new( '100', '1', '', a => $author ) >+ : MARC::Field->new( '700', '1', '', a => $author ); > $record->append_fields($marc_author); > } > if ($title) { >- my $marc_title = $marcflavour eq 'MARC21' ? MARC::Field->new( '245', '0', '0', a => $title ) : MARC::Field->new( '200', '0', '0', a => $title ); >+ my $marc_title = >+ $marcflavour eq 'MARC21' >+ ? MARC::Field->new( '245', '0', '0', a => $title ) >+ : MARC::Field->new( '200', '0', '0', a => $title ); > $record->append_fields($marc_title); > } > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 4df167d15fe..9bc3ebc4d20 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -19,13 +19,13 @@ package Koha::ILL::Request; > > use Modern::Perl; > >-use Clone qw( clone ); >-use Try::Tiny qw( catch try ); >+use Clone qw(clone); >+use Try::Tiny qw(catch try); > use DateTime; > > use C4::Letters; >-use Mojo::Util qw(deprecated); >-use File::Basename qw( dirname ); >+use Mojo::Util qw(deprecated); >+use File::Basename qw(dirname); > > use Koha::AuthorisedValue; > use Koha::AuthorisedValues; >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35570
:
159942
|
159943
|
159944
|
159946
|
159947
|
160452
|
160457
|
160654
|
160655
|
160656
|
160657
|
160658
|
160659
|
160660
|
160686
|
161519
|
161520
|
161521
|
161522
|
161523
|
161524
|
162894
|
162897
|
162898
|
162899
|
162900
|
162901
|
162902
|
162903
|
162904
|
162905
|
164277
|
164278
|
164279
|
164280
|
164281
|
164282
|
164283
|
164284
|
165204
|
165205
|
165206
|
165207
|
165208
|
165209
|
165210
|
165211
|
165286
|
165287
|
165288
|
165289
|
165290
|
165291
|
165292
|
165293
|
167050
|
167051
|
171312
|
171313
|
171314
|
171315
|
171316
|
171317
|
171318
|
171319
|
171320
|
171321
|
171322
|
171323
|
172218
|
172219
|
172722
|
172723
|
172724
|
172725
|
172726
|
172727
|
172728
|
172729
|
172730
|
172731
|
172732
|
172733
|
172734
|
172735
|
172740
|
172741
|
172742
|
172743
|
172744
|
172745
|
172746
|
172747
|
172748
|
172749
|
172750
|
172751
|
172752
|
172753
|
172780
|
172809
|
172811
|
173916
|
173917
|
173918