Bugzilla – Attachment 172738 Details for
Bug 35725
Generic master form does not keep patron and cardnumber when changing type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35725: Keep cardnumber and library data when changing request type
Bug-35725-Keep-cardnumber-and-library-data-when-ch.patch (text/plain), 2.14 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-10-14 17:58:49 UTC
(
hide
)
Description:
Bug 35725: Keep cardnumber and library data when changing request type
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-10-14 17:58:49 UTC
Size:
2.14 KB
patch
obsolete
>From 6e0de3b2684e25438157dbc416609b0e04d4e94e Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 8 Jan 2024 14:43:43 +0000 >Subject: [PATCH] Bug 35725: Keep cardnumber and library data when changing > request type > >Test plan: >1) Apply 35570 >2) Enable ILLModule sys pref through UI, or run: > echo "update systempreferences set value = 1 where variable = \"ILLModule\";" | koha-mysql kohadev >3) Create a new Standard request, visit: > http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >4) Input a cardnumber and/or set a library at the bottom under "Patron options". >5) Change the type (top of the form). Notice the data from step 4) is gone. >6) Apply patch. Repeat test plan and notice data is kept when changing request type. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Backend/intra-includes/create.inc | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/Koha/ILL/Backend/intra-includes/create.inc b/Koha/ILL/Backend/intra-includes/create.inc >index 54fc71a866c..4d222b844a6 100644 >--- a/Koha/ILL/Backend/intra-includes/create.inc >+++ b/Koha/ILL/Backend/intra-includes/create.inc >@@ -87,14 +87,18 @@ > Card number, username or surname: > </label> > <input type="text" name="cardnumber" id="cardnumber" autocomplete="off" >- type="text" value="" /> >+ type="text" value="[% whole.value.other.cardnumber | html %]" /> > </li> > <li> > <label class="required" for="branchcode">Destination library:</label> > <select id="branchcode" name="branchcode"> > <option value="" /> > [% FOREACH branch IN branches %] >- <option value="[% branch.branchcode | html %]"> >+ [% IF branch.branchcode == whole.value.other.branchcode %] >+ <option value="[% branch.branchcode | html %]" selected="selected"> >+ [% ELSE %] >+ <option value="[% branch.branchcode | html %]"> >+ [% END %] > [% branch.branchname | html %] > </option> > [% END %] >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35725
:
160629
|
160630
|
160650
|
160661
|
160662
| 172738 |
172739