Bugzilla – Attachment 172748 Details for
Bug 35570
Add a generic master form in ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35570: (QA follow-up): Rebase on final state of bug 35681
Bug-35570-QA-follow-up-Rebase-on-final-state-of-bu.patch (text/plain), 3.16 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-10-14 18:01:42 UTC
(
hide
)
Description:
Bug 35570: (QA follow-up): Rebase on final state of bug 35681
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-10-14 18:01:42 UTC
Size:
3.16 KB
patch
obsolete
>From 2992f9ff35d65d53260291e0f0e4c4a3e4c5c051 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 22 May 2024 14:40:28 +0000 >Subject: [PATCH] Bug 35570: (QA follow-up): Rebase on final state of bug 35681 > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../data/mysql/atomicupdate/bug_35570.pl | 30 +++++++++++++------ > 1 file changed, 21 insertions(+), 9 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_35570.pl b/installer/data/mysql/atomicupdate/bug_35570.pl >index 3fc574775e0..f1603182a0c 100755 >--- a/installer/data/mysql/atomicupdate/bug_35570.pl >+++ b/installer/data/mysql/atomicupdate/bug_35570.pl >@@ -1,8 +1,8 @@ > use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_failure say_success say_info); > > use C4::Context; > use Koha::Reports; >-use Term::ANSIColor; > > return { > bug_number => "35570", >@@ -19,7 +19,10 @@ return { > > if ($illbatches) { > $dbh->do("UPDATE illbatches SET backend = 'Standard' where backend = 'FreeForm'"); >- say $out colored( "Bug 35570: Updated ILL batches from 'FreeForm' to 'Standard'", 'green' ); >+ say_success( >+ $out, >+ "Bug 35570: Updated ILL batches from 'FreeForm' to 'Standard'" >+ ); > } > > my ($illrequestattributes) = $dbh->selectrow_array( >@@ -30,7 +33,10 @@ return { > > if ($illrequestattributes) { > $dbh->do("UPDATE illrequestattributes SET backend = 'Standard' where backend = 'FreeForm'"); >- say $out colored( "Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard'", 'green' ); >+ say_success( >+ $out, >+ "Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard'" >+ ); > } > > my ($illrequests) = $dbh->selectrow_array( >@@ -41,7 +47,10 @@ return { > > if ($illrequests) { > $dbh->do("UPDATE illrequests SET backend = 'Standard' where backend = 'FreeForm'"); >- say $out colored( "Bug 35570: Updated ILL requests from 'FreeForm' to 'Standard'", 'green' ); >+ say_success( >+ $out, >+ "Bug 35570: Updated ILL requests from 'FreeForm' to 'Standard'" >+ ); > } > > my $reports = join( >@@ -57,13 +66,16 @@ return { > ); > > if ($reports) { >- say $out colored( >- "Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found. The following reports MUST be updated accordingly ('FreeForm' -> 'Standard'):", >- 'yellow' >+ say_warning( >+ $out, >+ "Bug 35570: **ACTION REQUIRED**: Saved SQL reports containing occurrences of 'FreeForm' were found. The following reports MUST be updated accordingly ('FreeForm' -> 'Standard'):" >+ ); >+ say_info( >+ $out, >+ $reports > ); >- say $out colored( $reports, 'blue'); > } else { >- say $out "Bug 35570: Finished database update."; >+ say_info( $out, "Bug 35570: Finished database update." ); > } > > }, >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35570
:
159942
|
159943
|
159944
|
159946
|
159947
|
160452
|
160457
|
160654
|
160655
|
160656
|
160657
|
160658
|
160659
|
160660
|
160686
|
161519
|
161520
|
161521
|
161522
|
161523
|
161524
|
162894
|
162897
|
162898
|
162899
|
162900
|
162901
|
162902
|
162903
|
162904
|
162905
|
164277
|
164278
|
164279
|
164280
|
164281
|
164282
|
164283
|
164284
|
165204
|
165205
|
165206
|
165207
|
165208
|
165209
|
165210
|
165211
|
165286
|
165287
|
165288
|
165289
|
165290
|
165291
|
165292
|
165293
|
167050
|
167051
|
171312
|
171313
|
171314
|
171315
|
171316
|
171317
|
171318
|
171319
|
171320
|
171321
|
171322
|
171323
|
172218
|
172219
|
172722
|
172723
|
172724
|
172725
|
172726
|
172727
|
172728
|
172729
|
172730
|
172731
|
172732
|
172733
|
172734
|
172735
|
172740
|
172741
|
172742
|
172743
|
172744
|
172745
|
172746
|
172747
| 172748 |
172749
|
172750
|
172751
|
172752
|
172753
|
172780
|
172809
|
172811
|
173916
|
173917
|
173918