Bugzilla – Attachment 172752 Details for
Bug 35570
Add a generic master form in ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35570: Use ->extended_attributes()
Bug-35570-Use--extendedattributes.patch (text/plain), 2.33 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-10-14 18:01:57 UTC
(
hide
)
Description:
Bug 35570: Use ->extended_attributes()
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-10-14 18:01:57 UTC
Size:
2.33 KB
patch
obsolete
>From 39c47e990eb08a1fe314d5939b62bdc421f56b67 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 14 Oct 2024 11:30:53 -0300 >Subject: [PATCH] Bug 35570: Use ->extended_attributes() > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Backend/Standard.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index cb810da47e6..ee31397f240 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -143,7 +143,7 @@ that we do not consider to be metadata > > sub metadata { > my ( $self, $request ) = @_; >- my $attrs = $request->illrequestattributes; >+ my $attrs = $request->extended_attributes; > my $metadata = {}; > my @ignore = ( 'requested_partners', 'type', 'type_disclaimer_value', 'type_disclaimer_date' ); > my $core_fields = _get_core_fields(); >@@ -355,7 +355,7 @@ sub edititem { > my $stage = $other->{stage}; > if ( !$stage || $stage eq 'init' ) { > >- my $attrs = $params->{request}->illrequestattributes->unblessed; >+ my $attrs = $params->{request}->extended_attributes->unblessed; > > # We need to identify which parameters are custom, and pass them > # to the template in a predefined form >@@ -696,7 +696,7 @@ sub migrate { > > my @default_attributes = (qw/title type author year volume isbn issn article_title article_author pages/); > my $original_attributes = >- $original_request->illrequestattributes->search( { type => { '-in' => \@default_attributes } } ); >+ $original_request->extended_attributes->search( { type => { '-in' => \@default_attributes } } ); > > my $request_details = > { map { $_->type => $_->value } ( $original_attributes->as_list ) }; >@@ -727,7 +727,7 @@ sub migrate { > # Cleanup any outstanding work, close the request. > elsif ( $stage eq 'emigrate' ) { > my $new_request = $params->{request}; >- my $from_id = $new_request->illrequestattributes->find( { type => 'migrated_from' } )->value; >+ my $from_id = $new_request->extended_attributes->find( { type => 'migrated_from' } )->value; > my $request = Koha::ILL::Requests->find($from_id); > > # Just cancel the original request now it's been migrated away >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35570
:
159942
|
159943
|
159944
|
159946
|
159947
|
160452
|
160457
|
160654
|
160655
|
160656
|
160657
|
160658
|
160659
|
160660
|
160686
|
161519
|
161520
|
161521
|
161522
|
161523
|
161524
|
162894
|
162897
|
162898
|
162899
|
162900
|
162901
|
162902
|
162903
|
162904
|
162905
|
164277
|
164278
|
164279
|
164280
|
164281
|
164282
|
164283
|
164284
|
165204
|
165205
|
165206
|
165207
|
165208
|
165209
|
165210
|
165211
|
165286
|
165287
|
165288
|
165289
|
165290
|
165291
|
165292
|
165293
|
167050
|
167051
|
171312
|
171313
|
171314
|
171315
|
171316
|
171317
|
171318
|
171319
|
171320
|
171321
|
171322
|
171323
|
172218
|
172219
|
172722
|
172723
|
172724
|
172725
|
172726
|
172727
|
172728
|
172729
|
172730
|
172731
|
172732
|
172733
|
172734
|
172735
|
172740
|
172741
|
172742
|
172743
|
172744
|
172745
|
172746
|
172747
|
172748
|
172749
|
172750
|
172751
| 172752 |
172753
|
172780
|
172809
|
172811
|
173916
|
173917
|
173918