Bugzilla – Attachment 172780 Details for
Bug 35570
Add a generic master form in ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35570: Revert some strings translatability
Bug-35570-Revert-some-strings-translatability.patch (text/plain), 4.02 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-10-15 14:39:24 UTC
(
hide
)
Description:
Bug 35570: Revert some strings translatability
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-10-15 14:39:24 UTC
Size:
4.02 KB
patch
obsolete
>From 76ba327f9fab69943b41306a43d624aba94fce50 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 15 Oct 2024 11:36:32 -0300 >Subject: [PATCH] Bug 35570: Revert some strings translatability > >This patch reverts making core field descriptions translatable. It was >an obvious move and a needed one. But it turns out our core templates >are using those keys ('Author' and 'Title' in particular) and as such >translating them would break display (at least in the OPAC). Without >this patch, the ILL requests table in the OPAC doesn't display the title >and author columns values (i.e. displays 'N/A' instead) > >Added a FIXME in the code, and will file a bug soo we fix this properly. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Backend/Standard.pm | 64 ++++++++++++++++++++---------------- > 1 file changed, 35 insertions(+), 29 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 8696b322070..5222e965285 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -912,36 +912,42 @@ Return a hashref of core fields > =cut > > sub _get_core_fields { >+ # FIXME: This should all be made translatable as is basically a >+ # code => description mapping. The metadata() sub is using this >+ # descriptions as keys. I thought this was a bug on this backend >+ # but it turns out opac-illrequests.tt is using those descriptions >+ # as keys. for example: >+ # [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]... > return { >- article_author => __('Article author'), >- article_title => __('Article title'), >- associated_id => __('Associated ID'), >- author => __('Author'), >- chapter_author => __('Chapter author'), >- chapter => __('Chapter'), >- conference_date => __('Conference date'), >- doi => __('DOI'), >- editor => __('Editor'), >- institution => __('Institution'), >- isbn => __('ISBN'), >- issn => __('ISSN'), >- issue => __('Issue'), >- item_date => __('Date'), >- pages => __('Pages'), >- pagination => __('Pagination'), >- paper_author => __('Paper author'), >- paper_title => __('Paper title'), >- part_edition => __('Part / Edition'), >- publication => __('Publication'), >- published_date => __('Publication date'), >- published_place => __('Place of publication'), >- publisher => __('Publisher'), >- sponsor => __('Sponsor'), >- title => __('Title'), >- type => __('Type'), >- venue => __('Venue'), >- volume => __('Volume'), >- year => __('Year'), >+ article_author => 'Article author', >+ article_title => 'Article title', >+ associated_id => 'Associated ID', >+ author => 'Author', >+ chapter_author => 'Chapter author', >+ chapter => 'Chapter', >+ conference_date => 'Conference date', >+ doi => 'DOI', >+ editor => 'Editor', >+ institution => 'Institution', >+ isbn => 'ISBN', >+ issn => 'ISSN', >+ issue => 'Issue', >+ item_date => 'Date', >+ pages => 'Pages', >+ pagination => 'Pagination', >+ paper_author => 'Paper author', >+ paper_title => 'Paper title', >+ part_edition => 'Part / Edition', >+ publication => 'Publication', >+ published_date => 'Publication date', >+ published_place => 'Place of publication', >+ publisher => 'Publisher', >+ sponsor => 'Sponsor', >+ title => 'Title', >+ type => 'Type', >+ venue => 'Venue', >+ volume => 'Volume', >+ year => 'Year', > }; > } > >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35570
:
159942
|
159943
|
159944
|
159946
|
159947
|
160452
|
160457
|
160654
|
160655
|
160656
|
160657
|
160658
|
160659
|
160660
|
160686
|
161519
|
161520
|
161521
|
161522
|
161523
|
161524
|
162894
|
162897
|
162898
|
162899
|
162900
|
162901
|
162902
|
162903
|
162904
|
162905
|
164277
|
164278
|
164279
|
164280
|
164281
|
164282
|
164283
|
164284
|
165204
|
165205
|
165206
|
165207
|
165208
|
165209
|
165210
|
165211
|
165286
|
165287
|
165288
|
165289
|
165290
|
165291
|
165292
|
165293
|
167050
|
167051
|
171312
|
171313
|
171314
|
171315
|
171316
|
171317
|
171318
|
171319
|
171320
|
171321
|
171322
|
171323
|
172218
|
172219
|
172722
|
172723
|
172724
|
172725
|
172726
|
172727
|
172728
|
172729
|
172730
|
172731
|
172732
|
172733
|
172734
|
172735
|
172740
|
172741
|
172742
|
172743
|
172744
|
172745
|
172746
|
172747
|
172748
|
172749
|
172750
|
172751
|
172752
|
172753
| 172780 |
172809
|
172811
|
173916
|
173917
|
173918