Bugzilla – Attachment 172809 Details for
Bug 35570
Add a generic master form in ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35570: (QA follow-up): Fix DVD type
Bug-35570-QA-follow-up-Fix-DVD-type.patch (text/plain), 3.52 KB, created by
Pedro Amorim
on 2024-10-16 09:57:17 UTC
(
hide
)
Description:
Bug 35570: (QA follow-up): Fix DVD type
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-10-16 09:57:17 UTC
Size:
3.52 KB
patch
obsolete
>From c25205787b1d8fe9ef8320048669ce2b5fb8ec1a Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 16 Oct 2024 09:56:20 +0000 >Subject: [PATCH] Bug 35570: (QA follow-up): Fix DVD type > >I've added some DVD specific fields: language, format, genre, studio. >Happy to have this discussed and/or updated but hoping this is good enough for now. >To test: >1) Create an ILL request of 'DVD' type on both OPAC and Staff >2) Verify the form is shown without issues >3) Fill all fields and verify all fields are stored and shown correctly on both OPAC and STaff >--- > Koha/ILL/Backend/Standard.pm | 4 +++ > .../ILL/Backend/shared-includes/forms/dvd.inc | 33 +++++++++++++++++++ > 2 files changed, 37 insertions(+) > create mode 100644 Koha/ILL/Backend/shared-includes/forms/dvd.inc > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 5222e965285..f64908adff9 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -928,11 +928,14 @@ sub _get_core_fields { > conference_date => 'Conference date', > doi => 'DOI', > editor => 'Editor', >+ format => 'Format', >+ genre => 'Genre', > institution => 'Institution', > isbn => 'ISBN', > issn => 'ISSN', > issue => 'Issue', > item_date => 'Date', >+ language => 'Language', > pages => 'Pages', > pagination => 'Pagination', > paper_author => 'Paper author', >@@ -943,6 +946,7 @@ sub _get_core_fields { > published_place => 'Place of publication', > publisher => 'Publisher', > sponsor => 'Sponsor', >+ studio => 'Studio', > title => 'Title', > type => 'Type', > venue => 'Venue', >diff --git a/Koha/ILL/Backend/shared-includes/forms/dvd.inc b/Koha/ILL/Backend/shared-includes/forms/dvd.inc >new file mode 100644 >index 00000000000..e90a5819877 >--- /dev/null >+++ b/Koha/ILL/Backend/shared-includes/forms/dvd.inc >@@ -0,0 +1,33 @@ >+<fieldset id="dvd-standard-fieldset" class="rows"> >+ <legend>DVD details</legend> >+ <ol id="publication-standard-fields"> >+ <li> >+ <label for="title">Title:</label> >+ <input type="text" name="title" id="title" value="[% whole.value.other.title | html %]" /> >+ </li> >+ <li> >+ <label for="author">Author:</label> >+ <input type="text" name="author" id="author" value="[% whole.value.other.author | html %]" /> >+ </li> >+ <li> >+ <label for="studio">Studio:</label> >+ <input type="text" name="studio" id="studio" value="[% whole.value.other.studio | html %]" /> >+ </li> >+ <li> >+ <label for="genre">Genre:</label> >+ <input type="text" name="genre" id="genre" value="[% whole.value.other.genre | html %]" /> >+ </li> >+ <li> >+ <label for="year">Year:</label> >+ <input type="text" name="year" id="year" value="[% whole.value.other.year | html %]" /> >+ </li> >+ <li> >+ <label for="format">Format:</label> >+ <input type="text" name="format" id="format" value="[% whole.value.other.format | html %]" /> >+ </li> >+ <li> >+ <label for="language">Language:</label> >+ <input type="text" name="language" id="language" value="[% whole.value.other.language | html %]" /> >+ </li> >+ </ol> >+</fieldset> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35570
:
159942
|
159943
|
159944
|
159946
|
159947
|
160452
|
160457
|
160654
|
160655
|
160656
|
160657
|
160658
|
160659
|
160660
|
160686
|
161519
|
161520
|
161521
|
161522
|
161523
|
161524
|
162894
|
162897
|
162898
|
162899
|
162900
|
162901
|
162902
|
162903
|
162904
|
162905
|
164277
|
164278
|
164279
|
164280
|
164281
|
164282
|
164283
|
164284
|
165204
|
165205
|
165206
|
165207
|
165208
|
165209
|
165210
|
165211
|
165286
|
165287
|
165288
|
165289
|
165290
|
165291
|
165292
|
165293
|
167050
|
167051
|
171312
|
171313
|
171314
|
171315
|
171316
|
171317
|
171318
|
171319
|
171320
|
171321
|
171322
|
171323
|
172218
|
172219
|
172722
|
172723
|
172724
|
172725
|
172726
|
172727
|
172728
|
172729
|
172730
|
172731
|
172732
|
172733
|
172734
|
172735
|
172740
|
172741
|
172742
|
172743
|
172744
|
172745
|
172746
|
172747
|
172748
|
172749
|
172750
|
172751
|
172752
|
172753
|
172780
| 172809 |
172811
|
173916
|
173917
|
173918