Bugzilla – Attachment 172823 Details for
Bug 33736
Add bookings to collect circulation report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33736: Don't allow sorting on Location
Bug-33736-Dont-allow-sorting-on-Location.patch (text/plain), 1.73 KB, created by
Martin Renvoize (ashimema)
on 2024-10-16 15:01:44 UTC
(
hide
)
Description:
Bug 33736: Don't allow sorting on Location
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-16 15:01:44 UTC
Size:
1.73 KB
patch
obsolete
>From 6908c9e305177378ad97c9155b40b0501ffb3cc6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 16 Oct 2024 16:00:29 +0100 >Subject: [PATCH] Bug 33736: Don't allow sorting on Location > >We need some special handling to sort on Location as it's got both a >custom renderer and relies on _strings so the ordering and search won't >return expected results without some custom function building. >--- > .../intranet-tmpl/prog/en/modules/circ/pendingbookings.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt >index 485d3398aff..51f6fdb4019 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt >@@ -145,7 +145,7 @@ > "patron", > "pickup_library" > ], >- "order": [[ 1, "asc" ]], >+ "order": [[ 7, "asc" ]], > "columns": [{ > "data": "booking_id", > "title": "Booking ID", >@@ -196,10 +196,10 @@ > } > }, > { >- "data": "", >+ "data": "item.location", > "title": "Location", > "searchable": false, >- "orderable": true, >+ "orderable": false, > "render": function(data,type,row,meta) { > if ( row.item ) { > if ( row.item.checked_out_date ) { >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33736
:
158356
|
161044
|
165014
|
165144
|
165277
|
165278
|
165279
|
165280
|
170398
|
170399
|
170400
|
172716
|
172717
|
172718
|
172719
|
172720
|
172721
|
172765
|
172807
|
172808
|
172810
|
172823
|
172836
|
172837
|
172838
|
172839
|
172840
|
172841
|
172842
|
172843
|
172844
|
172845
|
173291
|
173292
|
173293
|
173294
|
173295
|
173296
|
173297
|
173298
|
173299
|
173300
|
173301
|
173302
|
173303
|
174582