Bugzilla – Attachment 172835 Details for
Bug 38188
Fix populating borrowernumberslist from patron_search_selections
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38188: fix populating the borrowenumberlist from patron_search_selections
0001-Bug-38188-fix-populating-the-borrowenumberlist-from-.patch (text/plain), 1.97 KB, created by
Johanna Räisä
on 2024-10-17 06:32:37 UTC
(
hide
)
Description:
Bug 38188: fix populating the borrowenumberlist from patron_search_selections
Filename:
MIME Type:
Creator:
Johanna Räisä
Created:
2024-10-17 06:32:37 UTC
Size:
1.97 KB
patch
obsolete
>From 326ffef3245eb94f601d7103e08508d11701dd94 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Johanna=20R=C3=A4is=C3=A4?= <johanna.raisa@gmail.com> >Date: Thu, 17 Oct 2024 09:15:32 +0300 >Subject: [PATCH] Bug 38188: fix populating the borrowenumberlist from > patron_search_selections > >This patch fixes the issue of populating the borrowernumberlist from patron_search_selections. >Adding borrowernumbers to the textarea randomly fails because the textarea is populated with the html() function. > >To test: >1) Go to the patron search >2) Select a few patrons >3) Click on the "Batch patron modification" button >4) Use browsers back button to go back to the patron search >5) Find patron_batchmod_form from browser inspector, open it. >6) Check that between the <textarea> tags, there are the borrowernumbers of the selected patrons. >7) Apply the patch >8) Repeat steps 1-6 >9) Check that <textarea> tags are not populated with the borrowernumbers of the selected patrons. >10) Remove the display:none from the textarea and check that the borrowernumbers are populated there. > >Sponsored-by: Koha-Suomi Oy >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 13bc58c91f..208bcb1034 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -247,7 +247,7 @@ > e.preventDefault(); > var patron_search_selections = JSON.parse( localStorage.getItem("patron_search_selections") ) || []; > if( patron_search_selections.length > 0 ){ >- $("#borrowernumberlist").html( patron_search_selections.join('\n') ); >+ $("#borrowernumberlist").val( patron_search_selections.join('\n') ); > $("#patron_batchmod_form").submit(); > } > }); >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38188
:
172835
|
172935
|
173506