Bugzilla – Attachment 172883 Details for
Bug 38175
Improve bookings behavior with new status field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38175: (QA follow-up) Remove superflous method
Bug-38175-QA-follow-up-Remove-superflous-method.patch (text/plain), 871 bytes, created by
Martin Renvoize (ashimema)
on 2024-10-17 14:10:07 UTC
(
hide
)
Description:
Bug 38175: (QA follow-up) Remove superflous method
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-17 14:10:07 UTC
Size:
871 bytes
patch
obsolete
>From c504703f2c251254f55d3e0b0ab11387feb03393 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 17 Oct 2024 09:22:41 +0100 >Subject: [PATCH] Bug 38175: (QA follow-up) Remove superflous method > >If all we're doing is calling SUPER, then we don't need to wrap ;P > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Booking.pm | 12 ------------ > 1 file changed, 12 deletions(-) > >diff --git a/Koha/Booking.pm b/Koha/Booking.pm >index d1a1d53e475..c0c1b67f8ba 100644 >--- a/Koha/Booking.pm >+++ b/Koha/Booking.pm >@@ -298,18 +298,6 @@ sub to_api_mapping { > return {}; > } > >-=head3 delete >- >- my $deleted = $booking->delete(); >- >-=cut >- >-sub delete { >- my ($self) = @_; >- my $deleted = $self->SUPER::delete($self); >- return $deleted; >-} >- > =head3 edit > > This method allows patching a booking >-- >2.47.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=172883">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38175
:
172770
|
172771
|
172772
|
172773
|
172814
|
172815
|
172816
|
172817
|
172880
|
172881
|
172882
|
172883
|
172884
|
173172
|
173173
|
173174
|
173175
|
173176
|
173177
|
173178
|
173201
|
173202
|
173203
|
173346
|
173915