Bugzilla – Attachment 172900 Details for
Bug 35717
Link suggestions to orders by adding ordernumber to suggestions table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35717: Fix rebase issue after bug 34478
Bug-35717-Fix-rebase-issue-after-bug-34478.patch (text/plain), 2.60 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-10-17 15:14:09 UTC
(
hide
)
Description:
Bug 35717: Fix rebase issue after bug 34478
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-10-17 15:14:09 UTC
Size:
2.60 KB
patch
obsolete
>From d47b54ce343f8089cf0deed53e14c615caf5c307 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 17 Oct 2024 11:32:26 -0300 >Subject: [PATCH] Bug 35717: Fix rebase issue after bug 34478 > >Some code was introduced and the block setting the `ordernumber` for the >suggestion when creating an order from a suggestion got located before >the actual order is created, and as such the suggestion got is >ordernumber set as NULL. >--- > acqui/addorder.pl | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) > >diff --git a/acqui/addorder.pl b/acqui/addorder.pl >index 04091131cc3..31d732624bb 100755 >--- a/acqui/addorder.pl >+++ b/acqui/addorder.pl >@@ -334,24 +334,6 @@ if ( $op eq 'cud-order' ) { > $orderinfo->{biblionumber} = $biblionumber; > } > >- # change suggestion status if applicable >- if ( my $suggestionid = $input->param('suggestionid') ) { >- ModSuggestion( >- { >- suggestionid => $suggestionid, >- biblionumber => $orderinfo->{biblionumber}, >- ordernumber => $orderinfo->{ordernumber}, >- STATUS => 'ORDERED', >- } >- ); >- if ( C4::Context->preference('PlaceHoldsOnOrdersFromSuggestions') ) { >- my $suggestion = Koha::Suggestions->find($suggestionid); >- if ($suggestion) { >- $suggestion->place_hold(); >- } >- } >- } >- > $orderinfo->{unitprice} = $orderinfo->{ecost} > if not defined $orderinfo->{unitprice} > or $orderinfo->{unitprice} eq ''; >@@ -370,6 +352,24 @@ if ( $op eq 'cud-order' ) { > $order->populate_with_prices_for_ordering(); > $order->store; > >+ # change suggestion status if applicable >+ if ( my $suggestionid = $input->param('suggestionid') ) { >+ ModSuggestion( >+ { >+ suggestionid => $suggestionid, >+ biblionumber => $orderinfo->{biblionumber}, >+ ordernumber => $order->ordernumber, >+ STATUS => 'ORDERED', >+ } >+ ); >+ if ( C4::Context->preference('PlaceHoldsOnOrdersFromSuggestions') ) { >+ my $suggestion = Koha::Suggestions->find($suggestionid); >+ if ($suggestion) { >+ $suggestion->place_hold(); >+ } >+ } >+ } >+ > # Log the order creation > if ( C4::Context->preference("AcquisitionLog") ) { > my $infos = {}; >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35717
:
160576
|
160577
|
160578
|
160579
|
160580
|
160581
|
160582
|
160583
|
164834
|
164835
|
164836
|
164837
|
164838
|
164839
|
164840
|
172871
|
172872
|
172873
|
172874
|
172875
|
172876
|
172877
|
172878
|
172899
| 172900 |
172901