Bugzilla – Attachment 172921 Details for
Bug 37301
Further improve how we build Vue components
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37301: Update cypress
Bug-37301-Update-cypress.patch (text/plain), 3.85 KB, created by
Pedro Amorim
on 2024-10-17 16:24:46 UTC
(
hide
)
Description:
Bug 37301: Update cypress
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-10-17 16:24:46 UTC
Size:
3.85 KB
patch
obsolete
>From 129ff8cf08a9ce11bb076465a991e33a20e2de13 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 17 Oct 2024 15:46:52 +0000 >Subject: [PATCH] Bug 37301: Update cypress > >Local packages were named 'package' on the delete confirmation dialog, but 'local package' on the deleted confirmation message. >Both these places now use the same i18n.display_name from the respective Resource component so these label tests need to be updated. >Same for local titles. > >Test plan: >cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts >cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts >cypress run --spec t/cypress/integration/ERM/Licenses_spec.ts >cypress run --spec t/cypress/integration/ERM/Titles_spec.ts >cypress run --spec t/cypress/integration/ERM/Packages_spec.ts >--- > t/cypress/integration/ERM/Packages_spec.ts | 6 +++--- > t/cypress/integration/ERM/Titles_spec.ts | 12 +++++++++--- > 2 files changed, 12 insertions(+), 6 deletions(-) > >diff --git a/t/cypress/integration/ERM/Packages_spec.ts b/t/cypress/integration/ERM/Packages_spec.ts >index 746b5b3bd1..cc3e0f03f7 100644 >--- a/t/cypress/integration/ERM/Packages_spec.ts >+++ b/t/cypress/integration/ERM/Packages_spec.ts >@@ -300,7 +300,7 @@ describe("Package CRUD operations", () => { > .contains("Delete") > .click(); > cy.get(".alert-warning.confirmation h1").contains( >- "remove this package" >+ "remove this local package" > ); > cy.contains(erm_package.name); > >@@ -322,7 +322,7 @@ describe("Package CRUD operations", () => { > .contains("Delete") > .click(); > cy.get(".alert-warning.confirmation h1").contains( >- "remove this package" >+ "remove this local package" > ); > cy.contains("Yes, delete").click(); > cy.get("main div[class='alert alert-info']") >@@ -361,7 +361,7 @@ describe("Package CRUD operations", () => { > > cy.get("#packages_show #toolbar").contains("Delete").click(); > cy.get(".alert-warning.confirmation h1").contains( >- "remove this package" >+ "remove this local package" > ); > cy.contains("Yes, delete").click(); > >diff --git a/t/cypress/integration/ERM/Titles_spec.ts b/t/cypress/integration/ERM/Titles_spec.ts >index 6d19e87a9d..4e19abce89 100644 >--- a/t/cypress/integration/ERM/Titles_spec.ts >+++ b/t/cypress/integration/ERM/Titles_spec.ts >@@ -452,7 +452,9 @@ describe("Title CRUD operations", () => { > cy.visit("/cgi-bin/koha/erm/eholdings/local/titles"); > > cy.get("#titles_list table tbody tr:first").contains("Delete").click(); >- cy.get(".alert-warning.confirmation h1").contains("remove this title"); >+ cy.get(".alert-warning.confirmation h1").contains( >+ "remove this local title" >+ ); > cy.contains(erm_title.publication_title); > > // Accept the confirmation dialog, get 500 >@@ -470,7 +472,9 @@ describe("Title CRUD operations", () => { > body: null, > }); > cy.get("#titles_list table tbody tr:first").contains("Delete").click(); >- cy.get(".alert-warning.confirmation h1").contains("remove this title"); >+ cy.get(".alert-warning.confirmation h1").contains( >+ "remove this local title" >+ ); > cy.contains("Yes, delete").click(); > cy.get("main div[class='alert alert-info']") > .contains("Local title") >@@ -515,7 +519,9 @@ describe("Title CRUD operations", () => { > ); > > cy.get("#eholdings_title_show #toolbar").contains("Delete").click(); >- cy.get(".alert-warning.confirmation h1").contains("remove this title"); >+ cy.get(".alert-warning.confirmation h1").contains( >+ "remove this local title" >+ ); > cy.contains("Yes, delete").click(); > > //Make sure we return to list after deleting from show >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37301
:
168709
|
168739
|
168740
|
168741
|
168800
|
168827
|
168828
|
168829
|
168836
|
172713
|
172911
|
172912
|
172913
|
172914
|
172915
|
172916
|
172917
|
172918
|
172919
|
172920
|
172921
|
174612
|
174613
|
174614
|
174615
|
174616
|
174617
|
174618
|
174619
|
174620
|
174621
|
174622
|
174623
|
174624
|
174625
|
174626
|
174627
|
174628
|
174629
|
174630
|
174631
|
175450
|
177173
|
177174
|
177175
|
177176
|
177177
|
177178
|
177179
|
177180
|
177181
|
177182
|
177183
|
177184
|
177185
|
177186
|
177187
|
177188
|
177189
|
177190
|
177191
|
177192
|
177193
|
177351