Bugzilla – Attachment 172939 Details for
Bug 37403
Wrong progress quantity in job details when staging records with match check
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37403: Wrong progress quantity in job details
Bug-37403-Wrong-progress-quantity-in-job-details.patch (text/plain), 1.96 KB, created by
Chris Cormack
on 2024-10-18 01:51:25 UTC
(
hide
)
Description:
Bug 37403: Wrong progress quantity in job details
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2024-10-18 01:51:25 UTC
Size:
1.96 KB
patch
obsolete
>From 48498148cfd0f9d4517a69ca2179fe01dce8ec37 Mon Sep 17 00:00:00 2001 >From: Hinemoea Viault <hinemoea.viault@inlibro.com> >Date: Wed, 24 Jul 2024 12:35:28 -0400 >Subject: [PATCH] Bug 37403: Wrong progress quantity in job details > >In fact the system adds a previous value to the progress. As if the system keeps a previous value and adds the correct count of records in addition. >This patch removes the previously stored value. > >To test: >1. Go to Cataloging > Stage records for import >2. Choose a file with bibliographic records and click Upload file >3. In "Look for existing records in catalog?" choose a record matching rule (e.g. ISBN) >4. Click Stage for import >5. Click View detail of the enqueued job > --> Progress show 2/1 >6. Apply the patch >7. Repeat steps 1 to 4 >8. Click View detail of the enqueued job > --> Progress show 1/1 > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> > >qa script: >Commit title does not start with 'Bug XXXXX: ' - d1bebb34d7 > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Fixed patch subject line >--- > Koha/BackgroundJob/StageMARCForImport.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob/StageMARCForImport.pm b/Koha/BackgroundJob/StageMARCForImport.pm >index 12723782795..e536ded50bf 100644 >--- a/Koha/BackgroundJob/StageMARCForImport.pm >+++ b/Koha/BackgroundJob/StageMARCForImport.pm >@@ -144,7 +144,7 @@ sub process { > $matcher_code = $matcher->code(); > $num_with_matches = > BatchFindDuplicates( $batch_id, $matcher, 10, 50, >- sub { my $job_progress = shift; $self->progress( $self->progress + $job_progress )->store } ); >+ sub { my $job_progress = shift; $self->progress( $job_progress )->store } ); > SetImportBatchMatcher( $batch_id, $matcher_id ); > SetImportBatchOverlayAction( $batch_id, $overlay_action ); > SetImportBatchNoMatchAction( $batch_id, $nomatch_action ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37403
:
169509
|
169519
| 172939