Attachment 172946 Details for Bug 35508 – Bug 35508: Update borrowers.updated_on when modifying a patron's attribute

[patch] Bug 35508: Update borrowers.updated_on when modifying a patron's attribute

Bug-35508-Update-borrowersupdatedon-when-modifying.patch (text/plain), 2.08 KB, created by Kyle M Hall (khall) on 2024-10-18 10:50:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-10-18 10:50:02 UTC

Size: 2.08 KB

patch

obsolete

>From 2e62f9225021a9780359d928eccf50ca3db26eb5 Mon Sep 17 00:00:00 2001
>From: Hammat Wele <hammat.wele@inlibro.com>
>Date: Thu, 14 Dec 2023 13:59:42 +0000
>Subject: [PATCH] Bug 35508: Update borrowers.updated_on when modifying a
> patron's attribute
>
>Currently, if you have patron attributes and modify the values in a patron's account, the patron's updated_on date is not updated. This patch makes the "Updated on" change when a patron attribute is updated.
>
>To test:
>
>1. Create a patron attribute type
>   1.1. Go to Administration > Patron attribute types
>   1.2. Click New patron attribute
>   1.3. Fill out the code and description
>   1.4. Click Save
>
>2. Edit a patron (normal)
>   2.1. Go to Patrons and find a patron account
>   2.2. Click Edit
>   2.3. Change a regular field (e.g. Middle name)
>   2.4. Click Save
>
>--> Notice the "Updated on" date in the left column has been updated to now
>
>3. Edit a patron attribute
>   3.1. In another patron account*, click Edit
>   3.2. Change the value of an attribute
>   3.3. Click Save
>
>--> Notice the "Updated on" date did not change
>
>4. Apply the patch
>   4.1 Repeat step 3.1, 3.2, 3.3
>
>--> Notice the "Updated on" date has now changed
>
>Signed-off-by: Esther <esther@bywatersolutions.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> members/memberentry.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 2227df425fb..5fcaf170b41 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -576,6 +576,7 @@ if ((!$nok) and $nodouble and ($op eq 'cud-insert' or $op eq 'cud-save')){
>         if (C4::Context->preference('ExtendedPatronAttributes') and $input->param('setting_extended_patron_attributes')) {
>             $patron->extended_attributes->filter_by_branch_limitations->delete;
>             $patron->extended_attributes($extended_patron_attributes);
>+            $patron->set( { updated_on => "" } )->store;
>         }
> 
>         if ( $destination eq 'circ' and not C4::Auth::haspermission( C4::Context->userenv->{id}, { circulate => 'circulate_remaining_permissions' } ) ) {
>-- 
>2.39.5 (Apple Git-154)

Actions: View | Diff | Splinter Review

Attachments on bug 35508: 159838 | 159895 | 165012 | 165013 | 166640 | 166641 | 167229 | 172946 | 172947 | 172948 | 172949