Bugzilla – Attachment 172988 Details for
Bug 37639
items.stack ( shelving control number ) not included in items API endpoint
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37639: Adjust tests
Bug-37639-Adjust-tests.patch (text/plain), 11.60 KB, created by
Lucas Gass (lukeg)
on 2024-10-18 16:28:04 UTC
(
hide
)
Description:
Bug 37639: Adjust tests
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-10-18 16:28:04 UTC
Size:
11.60 KB
patch
obsolete
>From 8215e271ae3814aba1d96ada2e1eb0b37598ccd5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 18 Oct 2024 14:39:48 +0000 >Subject: [PATCH] Bug 37639: Adjust tests > >--- > t/db_dependent/api/v1/items.t | 138 +++++++++++++++++++++++----------- > 1 file changed, 93 insertions(+), 45 deletions(-) > >diff --git a/t/db_dependent/api/v1/items.t b/t/db_dependent/api/v1/items.t >index 9ba55d39d64..622f3844557 100755 >--- a/t/db_dependent/api/v1/items.t >+++ b/t/db_dependent/api/v1/items.t >@@ -48,51 +48,99 @@ subtest 'to_api_mapping() tests' => sub { > $schema->storage->txn_begin; > > my $mapping = Koha::Item->to_api_mapping; >- is($mapping->{itemnumber}, 'item_id', 'items.itemnumber is mapped as item_id in to_api_mapping'); >- is($mapping->{biblionumber}, 'biblio_id', 'items.biblionumber is mapped as biblio_id in to_api_mapping'); >- is($mapping->{biblioitemnumber}, undef, 'items.biblionumber is mapped as undef in to_api_mapping'); >- is($mapping->{barcode}, 'external_id', 'items.barcode is mapped as external_id in to_api_mapping'); >- is($mapping->{dateaccessioned}, 'acquisition_date', 'items.dateaccessioned is mapped as acquisition_date in to_api_mapping'); >- is($mapping->{booksellerid}, 'acquisition_source', 'items.booksellerid is mapped as acquisition_source in to_api_mapping'); >- is($mapping->{homebranch}, 'home_library_id', 'items.homebranch is mapped as home_libray_id in to_api_mapping'); >- is($mapping->{price}, 'purchase_price', 'items.price is mapped as purchase_price in to_api_mapping'); >- is($mapping->{replacementprice}, 'replacement_price', 'items.replacementprice is mapped as replacement_price in to_api_mapping'); >- is($mapping->{replacementpricedate}, 'replacement_price_date', 'items.replacementpricedate is mapped as replacement_price_date in to_api_mapping'); >- is($mapping->{datelastborrowed}, 'last_checkout_date', 'items.datelastborrowered is mapped as last_checkout_date in to_api_mapping'); >- is($mapping->{datelastseen}, 'last_seen_date', 'items.datelastseen is mapped as last_seen_date in to_api_mapping'); >- is($mapping->{stack}, 'stack', 'items.stack is mapped as stack in to_api_mapping'); >- is($mapping->{notforloan}, 'not_for_loan_status', 'items.notforloan is mapped as not_for_loan_status in to_api_mapping'); >- is($mapping->{damaged}, 'damaged_status', 'items.damaged is mapped as damaged_status in to_api_mapping'); >- is($mapping->{damaged_on}, 'damaged_date', 'items.damaged_on is mapped as damaged_date in to_api_mapping'); >- is($mapping->{itemlost}, 'lost_status', 'items.itemlost is mapped as lost_status in to_api_mapping'); >- is($mapping->{itemlost_on}, 'lost_date', 'items.itemlost_on is mapped as lost_date in to_api_mapping'); >- is($mapping->{withdrawn}, 'withdrawn', 'items.withdrawn is mapped as withdrawn in to_api_mapping'); >- is($mapping->{withdrawn_on}, 'withdrawn_date', 'items.withdrawn_date is mapped as withdrawn in to_api_mapping'); >- is($mapping->{itemcallnumber}, 'callnumber', 'items.itemcallnumber is mapped as callnumber in to_api_mapping'); >- is($mapping->{coded_location_qualifier}, 'coded_location_qualifier', 'items.coded_location_qualifier is mapped as coded_location_qualifier in to_api_mapping'); >- is($mapping->{issues}, 'checkouts_count', 'items.issues is mapped as checkouts_count in to_api_mapping'); >- is($mapping->{renewals}, 'renewals_count', 'items.renewals is mapped as renewals_count in to_api_mapping'); >- is($mapping->{reserves}, 'holds_count', 'items.reserves is mapped as holds_count in to_api_mapping'); >- is($mapping->{restricted}, 'restricted_status', 'items.restricted is mapped as restricted_status in to_api_mapping'); >- is($mapping->{itemnotes}, 'public_notes', 'items.itemnotes is mapped as public_notes in to_api_mapping'); >- is($mapping->{itemnotes_nonpublic}, 'internal_notes', 'items.itemnotes_nonpublic is mapped as internal_notes in to_api_mapping'); >- is($mapping->{holdingbranch}, 'holding_library_id', 'items.holdingbranch is mapped as holding_library_id in to_api_mapping'); >- is($mapping->{timestamp}, 'timestamp', 'items.timestamp is mapped as timestamp in to_api_mapping'); >- is($mapping->{location}, 'location', 'items.location is mapped as location in to_api_mapping'); >- is($mapping->{permanent_location}, 'permanent_location', 'items.permanent_location is mapped as permanent_location in to_api_mapping'); >- is($mapping->{onloan}, 'checked_out_date', 'items.onloan is mapped as checked_out_date in to_api_mapping'); >- is($mapping->{cn_source}, 'call_number_source', 'items.cnsource is mapped as call_number_source in to_api_mapping'); >- is($mapping->{cn_sort}, 'call_number_sort', 'items.cnsort is mapped as call_number_sort in to_api_mapping'); >- is($mapping->{ccode}, 'collection_code', 'items.ccode is mapped as collection_code in to_api_mapping'); >- is($mapping->{materials}, 'materials_notes', 'items.materials is mapped as materials_notes in to_api_mapping'); >- is($mapping->{uri}, 'uri', 'items.uri is mapped as uri in to_api_mapping'); >- is($mapping->{itype}, 'item_type_id', 'items.itype is mapped as item_type_id in to_api_mapping'); >- is($mapping->{more_subfields_xml}, 'extended_subfields', 'items.more_subfields_xml is mapped as extended_subfields in to_api_mapping'); >- is($mapping->{enumchron}, 'serial_issue_number', 'items.enumchron is mapped as serial_issue_number in to_api_mapping'); >- is($mapping->{copynumber}, 'copy_number', 'items.copynumber is mapped as copy_number in to_api_mapping'); >- is($mapping->{stocknumber}, 'inventory_number', 'items.stocknumber is mapped as inventory_number in to_api_mapping'); >- is($mapping->{new_status}, 'new_status', 'items.new_status is mapped as new_status in to_api_mapping'); >- is($mapping->{deleted_on}, undef, 'items.deleted_on is mapped as undef in to_api_mapping'); >+ is( $mapping->{itemnumber}, 'item_id', 'items.itemnumber is mapped as item_id in to_api_mapping' ); >+ is( $mapping->{biblionumber}, 'biblio_id', 'items.biblionumber is mapped as biblio_id in to_api_mapping' ); >+ is( $mapping->{biblioitemnumber}, undef, 'items.biblionumber is mapped as undef in to_api_mapping' ); >+ is( $mapping->{barcode}, 'external_id', 'items.barcode is mapped as external_id in to_api_mapping' ); >+ is( >+ $mapping->{dateaccessioned}, 'acquisition_date', >+ 'items.dateaccessioned is mapped as acquisition_date in to_api_mapping' >+ ); >+ is( >+ $mapping->{booksellerid}, 'acquisition_source', >+ 'items.booksellerid is mapped as acquisition_source in to_api_mapping' >+ ); >+ is( $mapping->{homebranch}, 'home_library_id', 'items.homebranch is mapped as home_libray_id in to_api_mapping' ); >+ is( $mapping->{price}, 'purchase_price', 'items.price is mapped as purchase_price in to_api_mapping' ); >+ is( >+ $mapping->{replacementprice}, 'replacement_price', >+ 'items.replacementprice is mapped as replacement_price in to_api_mapping' >+ ); >+ is( >+ $mapping->{replacementpricedate}, 'replacement_price_date', >+ 'items.replacementpricedate is mapped as replacement_price_date in to_api_mapping' >+ ); >+ is( >+ $mapping->{datelastborrowed}, 'last_checkout_date', >+ 'items.datelastborrowered is mapped as last_checkout_date in to_api_mapping' >+ ); >+ is( >+ $mapping->{datelastseen}, 'last_seen_date', >+ 'items.datelastseen is mapped as last_seen_date in to_api_mapping' >+ ); >+ is( $mapping->{stack}, 'shelving_control_number', 'items.stack is mapped as stack in to_api_mapping' ); >+ is( >+ $mapping->{notforloan}, 'not_for_loan_status', >+ 'items.notforloan is mapped as not_for_loan_status in to_api_mapping' >+ ); >+ is( $mapping->{damaged}, 'damaged_status', 'items.damaged is mapped as damaged_status in to_api_mapping' ); >+ is( $mapping->{damaged_on}, 'damaged_date', 'items.damaged_on is mapped as damaged_date in to_api_mapping' ); >+ is( $mapping->{itemlost}, 'lost_status', 'items.itemlost is mapped as lost_status in to_api_mapping' ); >+ is( $mapping->{itemlost_on}, 'lost_date', 'items.itemlost_on is mapped as lost_date in to_api_mapping' ); >+ is( $mapping->{withdrawn}, 'withdrawn', 'items.withdrawn is mapped as withdrawn in to_api_mapping' ); >+ is( $mapping->{withdrawn_on}, 'withdrawn_date', 'items.withdrawn_date is mapped as withdrawn in to_api_mapping' ); >+ is( $mapping->{itemcallnumber}, 'callnumber', 'items.itemcallnumber is mapped as callnumber in to_api_mapping' ); >+ is( >+ $mapping->{coded_location_qualifier}, 'coded_location_qualifier', >+ 'items.coded_location_qualifier is mapped as coded_location_qualifier in to_api_mapping' >+ ); >+ is( $mapping->{issues}, 'checkouts_count', 'items.issues is mapped as checkouts_count in to_api_mapping' ); >+ is( $mapping->{renewals}, 'renewals_count', 'items.renewals is mapped as renewals_count in to_api_mapping' ); >+ is( $mapping->{reserves}, 'holds_count', 'items.reserves is mapped as holds_count in to_api_mapping' ); >+ is( >+ $mapping->{restricted}, 'restricted_status', >+ 'items.restricted is mapped as restricted_status in to_api_mapping' >+ ); >+ is( $mapping->{itemnotes}, 'public_notes', 'items.itemnotes is mapped as public_notes in to_api_mapping' ); >+ is( >+ $mapping->{itemnotes_nonpublic}, 'internal_notes', >+ 'items.itemnotes_nonpublic is mapped as internal_notes in to_api_mapping' >+ ); >+ is( >+ $mapping->{holdingbranch}, 'holding_library_id', >+ 'items.holdingbranch is mapped as holding_library_id in to_api_mapping' >+ ); >+ is( $mapping->{timestamp}, 'timestamp', 'items.timestamp is mapped as timestamp in to_api_mapping' ); >+ is( $mapping->{location}, 'location', 'items.location is mapped as location in to_api_mapping' ); >+ is( >+ $mapping->{permanent_location}, 'permanent_location', >+ 'items.permanent_location is mapped as permanent_location in to_api_mapping' >+ ); >+ is( $mapping->{onloan}, 'checked_out_date', 'items.onloan is mapped as checked_out_date in to_api_mapping' ); >+ is( >+ $mapping->{cn_source}, 'call_number_source', >+ 'items.cnsource is mapped as call_number_source in to_api_mapping' >+ ); >+ is( $mapping->{cn_sort}, 'call_number_sort', 'items.cnsort is mapped as call_number_sort in to_api_mapping' ); >+ is( $mapping->{ccode}, 'collection_code', 'items.ccode is mapped as collection_code in to_api_mapping' ); >+ is( $mapping->{materials}, 'materials_notes', 'items.materials is mapped as materials_notes in to_api_mapping' ); >+ is( $mapping->{uri}, 'uri', 'items.uri is mapped as uri in to_api_mapping' ); >+ is( $mapping->{itype}, 'item_type_id', 'items.itype is mapped as item_type_id in to_api_mapping' ); >+ is( >+ $mapping->{more_subfields_xml}, 'extended_subfields', >+ 'items.more_subfields_xml is mapped as extended_subfields in to_api_mapping' >+ ); >+ is( >+ $mapping->{enumchron}, 'serial_issue_number', >+ 'items.enumchron is mapped as serial_issue_number in to_api_mapping' >+ ); >+ is( $mapping->{copynumber}, 'copy_number', 'items.copynumber is mapped as copy_number in to_api_mapping' ); >+ is( >+ $mapping->{stocknumber}, 'inventory_number', >+ 'items.stocknumber is mapped as inventory_number in to_api_mapping' >+ ); >+ is( $mapping->{new_status}, 'new_status', 'items.new_status is mapped as new_status in to_api_mapping' ); >+ is( $mapping->{deleted_on}, undef, 'items.deleted_on is mapped as undef in to_api_mapping' ); > > is( scalar keys %{$mapping}, 45, 'Correct number of columns in mapping' ); > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37639
:
170299
|
170328
|
170329
|
170396
|
170397
|
170458
|
170782
|
172980
|
172988
|
173615
|
173616