Attachment 173040 Details for Bug 36118 – Bug 36118: Update status and send notice core actions logging

[patch] Bug 36118: Update status and send notice core actions logging

Bug-36118-Update-status-and-send-notice-core-actio.patch (text/plain), 3.99 KB, created by Pedro Amorim on 2024-10-21 11:25:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-21 11:25:38 UTC

Size: 3.99 KB

patch

obsolete

>From 673398ba16c2568f63b4f8068bc7dbe7ab361d9e Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 1 Apr 2024 12:24:54 +0000
>Subject: [PATCH] Bug 36118: Update status and send notice core actions logging
>
>1) Enable ILLlog sys pref
>2) Enable ILLModule and install 'FreeForm', run:
>bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
>3) Create a new FreeForm request, visit:
><INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
>4) You need to checkout FreeForm's branch compatible with 24.05:
>cd /kohadevbox/koha/Koha/Illbackends/FreeForm
>git checkout 24.05.x
>koha-plack --restart kohadev
>5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create'
>6) On the next screen, click 'Confirm request' and confirm.
>7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action.
>8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action.
>9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information.
>
>To my knowledge, these are the only 2 actions logged by core Logger.
>Backends logging their own actions that want patron information need to add it themselves following this pattern.
>
>Sponsored-by: UKHSA - UK Health Security Agency
>Sponsored-by: PTFS Europe Ltd
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
>---
> .../prog/en/modules/ill/log/patron_notice.tt | 10 ++++-----
> .../prog/en/modules/ill/log/status_change.tt | 22 +++++++++----------
> 2 files changed, 16 insertions(+), 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt
>index 7628789623..2d29747363 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt
>@@ -1,6 +1,6 @@
> [% USE KohaDates %]
>-
>-[% log.timestamp | $KohaDates with_hours => 1 %] : Patron notice sent: 
>-[% notice_code = log.info.notice_code %]
>-&quot;[% log.notice_types.$notice_code.name | html %]&quot;
>-
>+[% PROCESS 'ill-request-log.inc' %]
>+[% WRAPPER ill_request_log action_label = "Patron notice sent: " %]
>+ [% SET notice_code = log.info.notice_code %]
>+ &quot;[% log.notice_types.$notice_code.name | html %]&quot;
>+[% END %]
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
>index 5c18443165..ae6621117b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
>@@ -1,12 +1,12 @@
> [% USE KohaDates %]
>-
>-[% log.timestamp | $KohaDates with_hours => 1 %] : Status changed
>-[% IF log.info.status_before %]
>-[% before = log.info.status_before %]
>-[% display_before = log.aliases.$before ? log.aliases.$before.lib : request.capabilities.$before.name %]
>-from &quot;[% display_before | html %]&quot;
>-[% END %]
>-[% after = log.info.status_after %]
>-[% display_after = log.aliases.$after ? log.aliases.$after.lib : request.capabilities.$after.name %]
>-to &quot;[% display_after | html %]&quot;
>-
>+[% PROCESS 'ill-request-log.inc' %]
>+[% WRAPPER ill_request_log action_label = "Status changed" %]
>+ [% IF log.info.status_before %]
>+ [% before = log.info.status_before %]
>+ [% display_before = log.aliases.$before ? log.aliases.$before.lib : request.capabilities.$before.name %]
>+ from &quot;[% display_before | html %]&quot;
>+ [% END %]
>+ [% SET after = log.info.status_after %]
>+ [% SET display_after = log.aliases.$after ? log.aliases.$after.lib : request.capabilities.$after.name %]
>+ to &quot;[% display_after | html %]&quot;
>+[% END %]
>\ No newline at end of file
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 36118: 162277 | 162278 | 162279 | 162585 | 162586 | 162587 | 163178 | 163179 | 163180 | 163181 | 163283 | 163284 | 163285 | 163286 | 164181 | 164182 | 164183 | 164184 | 164185 | 164398 | 164399 | 164400 | 164401 | 164402 | 164405 | 164406 | 164407 | 164408 | 164409 | 170450 | 170451 | 170452 | 170453 | 170454 | 171372 | 171373 | 171374 | 171375 | 172785 | 172786 | 172787 | 172788 | 172789 | 173023 | 173024 | 173025 | 173026 | 173027 | 173028 | 173029 | 173030 | 173031 | 173032 | 173033 | 173034 | 173035 | 173036 | 173037 | 173038 | 173039 | 173040 | 173041