Attachment 173041 Details for Bug 36118 – Bug 36118: (QA follow-up): Make labels translatable

[patch] Bug 36118: (QA follow-up): Make labels translatable

Bug-36118-QA-follow-up-Make-labels-translatable.patch (text/plain), 3.14 KB, created by Pedro Amorim on 2024-10-21 11:25:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-21 11:25:42 UTC

Size: 3.14 KB

patch

obsolete

>From 39eadd536f0f70421093d1312e7566139002aaba Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 21 Oct 2024 11:07:15 +0000
>Subject: [PATCH] Bug 36118: (QA follow-up): Make labels translatable
>
>Also move the space+colon from 'Patron notice sent: ' label to ill-request-log.inc template
>Adjust status_change.tt 'From' capitalized because for status changed this is now:
>$ Status changed: From "New request" to "Requested"
>Instead of the previous:
>$ Status changed from "New request" to "Requested"
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/ill-request-log.inc | 2 +-
> .../intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt | 3 ++-
> .../intranet-tmpl/prog/en/modules/ill/log/status_change.tt | 5 +++--
> 3 files changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-request-log.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-request-log.inc
>index 8a4d96c042..965792be3d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-request-log.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-request-log.inc
>@@ -8,7 +8,7 @@
> [% PROCESS 'action-logs.inc' %]
> [% PROCESS translate_log_interface log_interface = log.interface %]
> [% END %]
>- - [% action_label | html %]
>+ - [% action_label | html %]: 
> [% content | $raw %]
> 
> [% END %]
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt
>index 2d29747363..5e067552bb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/patron_notice.tt
>@@ -1,6 +1,7 @@
> [% USE KohaDates %]
>+[% PROCESS 'i18n.inc' %]
> [% PROCESS 'ill-request-log.inc' %]
>-[% WRAPPER ill_request_log action_label = "Patron notice sent: " %]
>+[% WRAPPER ill_request_log action_label = t("Patron notice sent") %]
> [% SET notice_code = log.info.notice_code %]
> &quot;[% log.notice_types.$notice_code.name | html %]&quot;
> [% END %]
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
>index ae6621117b..e207703f2d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
>@@ -1,10 +1,11 @@
> [% USE KohaDates %]
>+[% PROCESS 'i18n.inc' %]
> [% PROCESS 'ill-request-log.inc' %]
>-[% WRAPPER ill_request_log action_label = "Status changed" %]
>+[% WRAPPER ill_request_log action_label = t("Status changed") %]
> [% IF log.info.status_before %]
> [% before = log.info.status_before %]
> [% display_before = log.aliases.$before ? log.aliases.$before.lib : request.capabilities.$before.name %]
>- from &quot;[% display_before | html %]&quot;
>+ From &quot;[% display_before | html %]&quot;
> [% END %]
> [% SET after = log.info.status_after %]
> [% SET display_after = log.aliases.$after ? log.aliases.$after.lib : request.capabilities.$after.name %]
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 36118: 162277 | 162278 | 162279 | 162585 | 162586 | 162587 | 163178 | 163179 | 163180 | 163181 | 163283 | 163284 | 163285 | 163286 | 164181 | 164182 | 164183 | 164184 | 164185 | 164398 | 164399 | 164400 | 164401 | 164402 | 164405 | 164406 | 164407 | 164408 | 164409 | 170450 | 170451 | 170452 | 170453 | 170454 | 171372 | 171373 | 171374 | 171375 | 172785 | 172786 | 172787 | 172788 | 172789 | 173023 | 173024 | 173025 | 173026 | 173027 | 173028 | 173029 | 173030 | 173031 | 173032 | 173033 | 173034 | 173035 | 173036 | 173037 | 173038 | 173039 | 173040 | 173041