Attachment 173042 Details for Bug 37850 – Bug 37850: (QA follow-up): Update illemail REST API attribute name

[patch] Bug 37850: (QA follow-up): Update illemail REST API attribute name

Bug-37850-QA-follow-up-Update-illemail-REST-API-at.patch (text/plain), 1.49 KB, created by Pedro Amorim on 2024-10-21 11:35:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-21 11:35:19 UTC

Size: 1.49 KB

patch

obsolete

>From 2638ef77dd0bf71a62dda04957ba9daee6c41162 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 21 Oct 2024 11:33:46 +0000
>Subject: [PATCH] Bug 37850: (QA follow-up): Update illemail REST API attribute
> name
>
>To test
>1) yarn api:bundle && koha-plack --restart kohadev
>2) Enable ILLModule and put some 'ILL staff email:' on some library
>3) Access <staff_url>/api/v1/libraries
>4) Notice the attribute reads ill_email
>---
> Koha/Library.pm                         | 2 +-
> api/v1/swagger/definitions/library.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Library.pm b/Koha/Library.pm
>index 2fb7e4fef3..8056c70292 100644
>--- a/Koha/Library.pm
>+++ b/Koha/Library.pm
>@@ -361,7 +361,7 @@ sub to_api_mapping {
>         branchphone      => 'phone',
>         branchfax        => 'fax',
>         branchemail      => 'email',
>-        branchillemail   => 'illemail',
>+        branchillemail   => 'ill_email',
>         branchreplyto    => 'reply_to_email',
>         branchreturnpath => 'return_path_email',
>         branchurl        => 'url',
>diff --git a/api/v1/swagger/definitions/library.yaml b/api/v1/swagger/definitions/library.yaml
>index 2d3f86d98f..0fc7967358 100644
>--- a/api/v1/swagger/definitions/library.yaml
>+++ b/api/v1/swagger/definitions/library.yaml
>@@ -59,7 +59,7 @@ properties:
>       - string
>       - "null"
>     description: the primary email address of the library
>-  illemail:
>+  ill_email:
>     type:
>       - string
>       - "null"
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37850: 171102 | 172000 | 172003 | 173042