Attachment 173113 Details for Bug 35287 – Bug 35287: (QA follow-up): Add v-bind:key

[patch] Bug 35287: (QA follow-up): Add v-bind:key

Bug-35287-QA-follow-up-Add-v-bindkey.patch (text/plain), 2.75 KB, created by Victor Grousset/tuxayo on 2024-10-22 01:47:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2024-10-22 01:47:29 UTC

Size: 2.75 KB

patch

obsolete

>From 2d454f4690aeec76b9878eb8c8262db1e7d74ff1 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 21 Oct 2024 10:31:24 +0000
>Subject: [PATCH] Bug 35287: (QA follow-up): Add v-bind:key
>
>Remove more unused imports
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../prog/js/vue/components/AdditionalFieldsDisplay.vue    | 8 ++++----
> .../prog/js/vue/components/AdditionalFieldsEntry.vue      | 7 +++++--
> 2 files changed, 9 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsDisplay.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsDisplay.vue
>index a9cda25329..e642d080a4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsDisplay.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsDisplay.vue
>@@ -6,7 +6,10 @@
>     >
>         <legend>{{ $__("Additional fields") }}</legend>
>         <ol>
>-            <li v-for="additional_field_value in additional_field_values">
>+            <li
>+                v-for="additional_field_value in additional_field_values"
>+                v-bind:key="additional_field_value.id"
>+            >
>                 <label
>                     :for="`additional_field_` + additional_field_value.field_id"
>                 >
>@@ -19,9 +22,6 @@
> </template>
> 
> <script>
>-import { inject } from "vue"
>-import { APIClient } from "../fetch/api-client.js"
>-
> export default {
>     data() {
>         return {
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue
>index 71ae8fc0d2..73fadb5369 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue
>@@ -6,7 +6,10 @@
>     >
>         <legend>{{ $__("Additional fields") }}</legend>
>         <ol>
>-            <template v-for="available_field in available_fields">
>+            <template
>+                v-for="available_field in available_fields"
>+                v-bind:key="available_field.extended_attribute_type_id"
>+            >
>                 <template
>                     v-if="
>                         available_field.authorised_value_category_name &&
>@@ -84,6 +87,7 @@
>                         v-for="current in current_additional_fields_values[
>                             available_field.extended_attribute_type_id
>                         ]"
>+                        v-bind:key="current.id"
>                     >
>                         <label
>                             :for="
>@@ -121,7 +125,6 @@
> </template>
> 
> <script>
>-import { inject } from "vue"
> import { APIClient } from "../fetch/api-client.js"
> 
> export default {
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 35287: 158725 | 158726 | 158727 | 158728 | 158729 | 158730 | 158731 | 158732 | 158733 | 158734 | 159634 | 159635 | 159636 | 159637 | 159638 | 159639 | 159640 | 159641 | 159642 | 159643 | 165451 | 165637 | 165638 | 165639 | 165640 | 165641 | 165642 | 165643 | 165644 | 165645 | 165646 | 165647 | 167681 | 169728 | 169729 | 169730 | 169731 | 169732 | 169733 | 169734 | 169735 | 169736 | 169737 | 170448 | 170753 | 172850 | 172851 | 172852 | 172853 | 172854 | 172855 | 172856 | 172857 | 172858 | 172860 | 172861 | 173022 | 173102 | 173103 | 173104 | 173105 | 173106 | 173107 | 173108 | 173109 | 173110 | 173111 | 173112 | 173113 | 173290