Bugzilla – Attachment 173131 Details for
Bug 38221
Add Bootstrap styling to pagination in authority plugin search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38221: Add Bootstrap styling to pagination in authority plugin search results
Bug-38221-Add-Bootstrap-styling-to-pagination-in-a.patch (text/plain), 9.45 KB, created by
Owen Leonard
on 2024-10-22 12:07:17 UTC
(
hide
)
Description:
Bug 38221: Add Bootstrap styling to pagination in authority plugin search results
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-10-22 12:07:17 UTC
Size:
9.45 KB
patch
obsolete
>From f7291a0700e4a3a238d7cd4d93dcb637c81f32e6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 22 Oct 2024 10:46:58 +0000 >Subject: [PATCH] Bug 38221: Add Bootstrap styling to pagination in authority > plugin search results > >This patch updates the markup of pagination links in the authority >search popup so that they have Bootstrap styling consistent with other >pages (e.g. catalog search results). > >The pagination markup has also been moved to a BLOCK so that it can be >reused instead of duplicated on the page. > >To test, apply the patch and go to Cataloging -> New record (using the >basic MARC editor). > >- Switch to tab 1 and click the tag editor link next to tag 100 subfield > a. >- Perform a search in the popup window which will return multiple pages > of results (an empty search will work with default testing data). >- Confirm that the pagination links are styled like catalog search > results. >- Confirm that the search links work correctly and that the correct > number is highlighted as you page through results. > >Sponsored-by: Athens County Public Libraries >--- > .../prog/en/includes/auth-finder-search.inc | 2 +- > .../authorities/searchresultlist-auth.tt | 87 +++++++++---------- > 2 files changed, 43 insertions(+), 46 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc >index 39ce49d278..f9ff82c907 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc >@@ -5,7 +5,7 @@ > <div class="btn-group"><a href="#" id="clear" class="btn btn-default btn-sm"><i class="fa fa-trash-can"></i> Clear field</a></div> > <div class="btn-group"><a href="#" id="createnew" class="btn btn-default btn-sm"><i class="fa fa-plus"></i> Create new authority</a></div> > </div> >-<form name="f" method="get" action="auth_finder.pl"> >+<form name="f" method="get" action="auth_finder.pl" class="clearfix"> > <input type="hidden" name="source" value="[% source | html %]" /> > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt >index 2b1e9ce345..f96f30f856 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt >@@ -22,42 +22,56 @@ > </style> > </head> > >-<body id="auth_searchresultlist_auth" class="auth"> >- <div class="container-fluid"> >- >- <h1>Authority search results</h1> >- [% INCLUDE 'auth-finder-search.inc' %] >- [% IF ( total ) %]<div class="resultnumber"> >- [% IF ( displayprev ) %] >- <a href="auth_finder.pl?startfrom=[% startfromprev | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >- << >- </a> >+[% BLOCK result_page_numbers %] >+ <div class="resultnumber clearfix"> >+ <nav> >+ <ul class="pagination"> >+ [% IF ( displayprev ) %] >+ <li class="page-item"> >+ <a class="page-link" href="auth_finder.pl?startfrom=[% startfromprev | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranetamp;&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >+ <i class="fa fa-fw fa-angle-left"></i> Previous >+ </a> >+ </li> > [% END %] > [% FOREACH number IN numbers %] > [% IF ( number.highlight ) %] >- [% number.number | html %] >+ <li class="page-item active"> >+ <a class="page-link" href="#">[% number.number | html %]</a> > [% ELSE %] >- <a href="auth_finder.pl?startfrom=[% number.startfrom | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN number.searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >- [% number.number | html %]</a> >+ <li class="page-item"> >+ <a class="page-link" href="auth_finder.pl?startfrom=[% number.startfrom | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN number.searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >+ [% number.number | html %]</a> >+ </li> > [% END %] > [% END %] > [% IF ( displaynext ) %] >- <a href="auth_finder.pl?startfrom=[% startfromnext | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >- >></a> >+ <li class="page-item"> >+ <a class="page-link" href="auth_finder.pl?startfrom=[% startfromnext | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >+ Next <i class="fa fa-fw fa-angle-right"></i> >+ </a> >+ </li> > [% END %] >- <div> >- >- <p><strong>Results [% from | html %] to [% to | html %] of [% total | html %]</strong></p> >- [% ELSE %] >- >- >- </div> >+ </ul> >+ </nav> >+ </div> >+[% END %] >+ >+<body id="auth_searchresultlist_auth" class="auth"> >+ <div class="container-fluid"> >+ >+ <h1>Authority search results</h1> >+ [% INCLUDE 'auth-finder-search.inc' %] >+ [% IF ( result ) %] >+ <p><strong>Results [% from | html %] to [% to | html %] of [% total | html %]</strong></p> >+ [% PROCESS 'result_page_numbers' %] >+ [% ELSE %] > <div class="alert alert-info"> > <p>No results found</p> > </div> >- [% END %] >- </div> >- [% IF ( result ) %]<div id="resultlist"> >+ [% END %] >+ >+ [% IF ( result ) %] >+ <div id="resultlist" class="page-section"> > <table> > <tr> > <th>Summary</th> >@@ -106,27 +120,10 @@ > </tr> > [% END %] > </table> >- > </div> >- <div class="resultnumber"> >- [% IF ( displayprev ) %] >- <a href="auth_finder.pl?startfrom=[% startfromprev | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranetamp;&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >- << >- </a> >- [% END %] >- [% FOREACH number IN numbers %] >- [% IF ( number.highlight ) %] >- [% number.number | html %] >- [% ELSE %] >- <a href="auth_finder.pl?startfrom=[% number.startfrom | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN number.searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >- [% number.number | html %]</a> >- [% END %] >- [% END %] >- [% IF ( displaynext ) %] >- <a href="auth_finder.pl?startfrom=[% startfromnext | uri %]&authtypecode=[% authtypecode | uri %][% FOREACH searchdat IN searchdata %]&[% searchdat.term | uri %]=[% searchdat.val | uri %][% END %]&op=do_search&type=intranet&index=[% index | uri %]&tagid=[% tagid | uri %]&orderby=[% orderby | uri %]&source=[% source | uri %]"> >- >></a> >- [% END %] >- </div>[% END %] >+ [% PROCESS 'result_page_numbers' %] >+ [% END %] >+ > </div> > > [% INCLUDE 'authority-detail-modal.inc' %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38221
:
173131
|
173186