Bugzilla – Attachment 173169 Details for
Bug 38148
Check value of holdallowed circ rule properly (Bug 29087 follow-up)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38148: Check value of holdallowed circ rule properly
Bug-38148-Check-value-of-holdallowed-circ-rule-pro.patch (text/plain), 1.80 KB, created by
Pedro Amorim
on 2024-10-22 15:34:38 UTC
(
hide
)
Description:
Bug 38148: Check value of holdallowed circ rule properly
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-10-22 15:34:38 UTC
Size:
1.80 KB
patch
obsolete
>From 815cb7c04f4c359ea02cac912bc3df6c6ce7be42 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Fri, 11 Oct 2024 01:53:11 +0000 >Subject: [PATCH] Bug 38148: Check value of holdallowed circ rule properly > >It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. > >To test: > >1. Apply patch and restart services >2. Search for a record on the OPAC. Confirm you can see a link to place a hold. >3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. >4. Confirm tests still pass t/db_dependent/Koha/Holds.t > >Sponsored-by: Whanganui District Council >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> >Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> >--- > Koha/Items.pm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/Koha/Items.pm b/Koha/Items.pm >index 1676a87597..8ef9f6f038 100644 >--- a/Koha/Items.pm >+++ b/Koha/Items.pm >@@ -61,14 +61,16 @@ placing a hold on one of those items. > sub filter_by_for_hold { > my ($self) = @_; > >- my $default_rule = Koha::CirculationRules->get_effective_rule( >+ my $default_rule = Koha::CirculationRules->get_effective_rule_value( > { > rule_name => 'holdallowed', >- rule_value => 'not_allowed', >+ itemtype => undef, >+ branchcode => undef, >+ categorycode => undef, > } > ); > my @hold_not_allowed_itypes; >- if ($default_rule) { >+ if ($default_rule eq 'not_allowed') { > @hold_not_allowed_itypes = Koha::ItemTypes->search->get_column('itemtype'); > my @hold_allowed_itypes = Koha::CirculationRules->search( > { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38148
:
172680
|
172681
|
172929
|
173125
|
173141
|
173142
|
173143
|
173144
|
173169
|
173170
|
173183
|
173184
|
173185
|
173205
|
173206
|
173207
|
173208