Bugzilla – Attachment 173193 Details for
Bug 38200
Remove dead code to delete authorities in authorities/authorities.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl
Bug-38200-Remove-dead-code-to-delete-authorities-i.patch (text/plain), 2.88 KB, created by
Jonathan Druart
on 2024-10-23 08:04:26 UTC
(
hide
)
Description:
Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-10-23 08:04:26 UTC
Size:
2.88 KB
patch
obsolete
>From 4be498d7d0ba7bad803d56314b14f764bfaa6462 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Thu, 17 Oct 2024 20:16:14 -0700 >Subject: [PATCH] Bug 38200: Remove dead code to delete authorities in > authorities/authorities.pl > >It has probably never been used. There's no sign of any UI to delete from >the authority editor or auth_finder in the last 13 years of templates, and >it was unused when it landed; the patch that actually made the first patch >work, a month later, put deleting authorities in authorities_home.pl, where >it has been ever since. > >It certainly hasn't been used since bug 17600 landed in 2021, since it >doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to >use it you just get an error for your trouble. > >Sponsored-by: Chetco Community Public Library >Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com> > >Amended-by: Jonathan Druart >tidy > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > authorities/authorities.pl | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 761c1f529d0..2133008f4fd 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -540,7 +540,6 @@ my $error = $input->param('error'); > my $authid = $input->param('authid') =~ s/\D//gr > ; # if authid exists, it's a modif, not a new authority. We remove from authid all non-digit characters just in case the CGI parameter contains weird characters like spaces > my $op = $input->param('op'); >-my $nonav = $input->param('nonav'); > my $myindex = $input->param('index'); > my $linkid=$input->param('linkid'); > my $authtypecode = $input->param('authtypecode'); >@@ -570,7 +569,7 @@ my ($template, $loggedinuser, $cookie) > type => "intranet", > flagsrequired => {editauthorities => 1}, > }); >-$template->param(nonav => $nonav,index=>$myindex,authtypecode=>$authtypecode,breedingid=>$breedingid, count=>$count); >+$template->param( index => $myindex, authtypecode => $authtypecode, breedingid => $breedingid, count => $count ); > > $tagslib = GetTagsLabels(1,$authtypecode); > $mandatory_z3950 = GetMandatoryFieldZ3950($authtypecode); >@@ -632,15 +631,6 @@ if ($op eq "cud-add") { > duplicateauthvalue => $duplicateauthvalue->{'authorized'}->[0]->{'heading'}, > ); > } >-} elsif ($op eq "cud-delete") { >-#------------------------------------------------------------------------------------------------------------------------------ >- DelAuthority({ authid => $authid }); >- if ($nonav){ >- print $input->redirect("auth_finder.pl"); >- }else{ >- print $input->redirect("authorities-home.pl?authid=0"); >- } >- exit; > } else { > if ( $op eq "duplicate" ) { > $authid = ""; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38200
:
172940
|
173171
| 173193