Attachment 173234 Details for Bug 38243 – Bug 38243: Remove DT's header_filter custom param

[patch] Bug 38243: Remove DT's header_filter custom param

Bug-38243-Remove-DTs-headerfilter-custom-param.patch (text/plain), 2.44 KB, created by David Nind on 2024-10-23 18:18:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-23 18:18:15 UTC

Size: 2.44 KB

patch

obsolete

>From 0e99de03b2c59dc8ba18275a472b5ce2755ca340 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 23 Oct 2024 16:49:27 +0200
>Subject: [PATCH] Bug 38243: Remove DT's header_filter custom param
>
>It seems to be a leftover from bug 32401, the code does not make sense:
>
> 569                 if(options.header_filter) {
> 570                     options.query_parameters = query_parameters;
> 571                 } else {
> 572                     dataSet.q = query_parameters;
> 573                     delete options.query_parameters;
> 574                 }
>
>Then options.query_parameters is never used.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/acqui/orderreceive.tt              |  1 -
> koha-tmpl/intranet-tmpl/prog/js/datatables.js          | 10 ++--------
> 2 files changed, 2 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 9daac07657..3842519e91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -1026,7 +1026,6 @@
>                     "ajax": {
>                         "url": pending_orders_url + "?q=" + encodeURI(JSON.stringify(base_query))
>                     },
>-                    "header_filter": true,
>                     "embed": [
>                         "invoice",
>                         "basket"
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index bfa9514f7d..5cc41bdee9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -625,15 +625,9 @@ function _dt_default_ajax (params){
> 
>             if(query_parameters.length) {
>                 query_parameters = JSON.stringify(query_parameters.length === 1?query_parameters[0]:{"-and": query_parameters});
>-                if(options.header_filter) {
>-                    options.query_parameters = query_parameters;
>-                } else {
>-                    dataSet.q = query_parameters;
>-                    delete options.query_parameters;
>-                }
>-            } else {
>-                delete options.query_parameters;
>+                dataSet.q = query_parameters;
>             }
>+            delete options.query_parameters;
> 
>             dataSet._match = options.criteria;
> 
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38243: 173221 | 173222 | 173234 | 173235 | 173513 | 173514