Bugzilla – Attachment 17325 Details for
Bug 10002
Don't include line breaks in strings that are translated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10002 - Don't include line breaks in strings that are translated
Bug-10002---Dont-include-line-breaks-in-strings-th.patch (text/plain), 2.77 KB, created by
Chris Cormack
on 2013-04-09 21:49:28 UTC
(
hide
)
Description:
Bug 10002 - Don't include line breaks in strings that are translated
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-04-09 21:49:28 UTC
Size:
2.77 KB
patch
obsolete
>From 1a8e3d59a21b05853b887c51c6984336553eb412 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 9 Apr 2013 15:44:45 -0400 >Subject: [PATCH] Bug 10002 - Don't include line breaks in strings that are > translated > >Several JS alert messages contain "\n" which is problematic for >translation. This patch removes those instances (a line break is not >strictly necessary anyway). Also corrected: two instances of "holds(s)" > >To test, place a hold on a title with items. From the biblio detail page >choose Edit -> Delete all items and Edit -> Delete record. In each case >you should see error messages with no line breaks and no misspellings. > >Delete all items attached to the record with holds from the item edit >page. Go back to the detail page and choose Edit -> Delete record. You >should see an error message about existing hold(s) with no line breaks >or misspellings. > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >Harmless change, fixes misspellings and makes translations easier >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 2dde5ad..f669d2c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -34,9 +34,9 @@ > > var is_confirmed; > if (count > 0){ >- is_confirmed = alert( count + " " +_("item(s) are attached to this record.\nYou must delete all items before deleting this record.") ); >+ is_confirmed = alert( count + " " +_("item(s) are attached to this record. You must delete all items before deleting this record.") ); > } else if ( holdcount > 0 ) { >- is_confirmed = confirm( holdcount + " " + _("holds(s) for this record \n Are you sure you want to delete this record?.")); >+ is_confirmed = confirm( holdcount + " " + _("hold(s) on this record. Are you sure you want to delete this record?.")); > } else { > is_confirmed = confirm(_("Are you sure you want to delete this record?")); > } >@@ -59,7 +59,7 @@ > var holdcount = [% holdcount %]; > > if ( holdcount > 0 ) { >- alert( holdcount + " " + _("holds(s) for this record \n You must delete all holds before deleting all items.") ); >+ alert( holdcount + " " + _("hold(s) on this record. You must delete all holds before deleting all items.") ); > } else if ( count > 0 ) { > if( confirm( _("Are you sure you want to delete the") + " " + count + " " + _("attached items?") ) ) { > window.location="/cgi-bin/koha/cataloguing/additem.pl?op=delallitems&biblionumber=[% biblionumber %]"; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10002
:
17319
|
17325
|
17340