Attachment 173251 Details for Bug 38117 – Bug 38117: Only show 'not checked in' message if item is checked out

[patch] Bug 38117: Only show 'not checked in' message if item is checked out

Bug-38117-Only-show-not-checked-in-message-if-item.patch (text/plain), 2.02 KB, created by Martin Renvoize (ashimema) on 2024-10-24 06:46:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-24 06:46:23 UTC

Size: 2.02 KB

patch

obsolete

>From 463ecc3c22cddc31b0280628a0358d6ae2159e4f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 8 Oct 2024 11:11:54 +0000
>Subject: [PATCH] Bug 38117: Only show 'not checked in' message if item is
> checked out
>
>To test:
> 1 - Enable system preference 'ShowAllCheckins'
> 2 - Set system preference 'BlockReturnOfWithdrawnItems' to 'Block'
> 3 - Check in an item
> 4 - Note 'Item was not checked in message'
> 5 - Confirm it happens for any item that is not currently issued
> 6 - Check out an item to a patron
> 7 - Mark the item as withdrawn
> 8 - Check the item in
> 9 - Note message 'Item was not checked in' appears too
>10 - Apply patch
>11 - Confirm checking in an item not checked out only shows 'Not checked out'
>12 - Confirm the withdrawn item still shows 'Item was not checked in'
>13 - Confirm above message remains whne checking in more items that were not issued
>
>Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 9d14bf5ecd5..01a40f7d412 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -1264,7 +1264,7 @@
>                                     [% FOREACH riloo IN riloop %]
>                                         <tr>
>                                             <td class="ci-duedate">
>-                                                [% IF ( riloo.not_returned ) %]
>+                                                [% IF ( riloo.not_returned AND riloo.duedate ) %]
>                                                     <span class="problem not_returned">Item was not checked in</span>
>                                                 [% END %]
>                                                 [% IF ( riloo.duedate ) %]
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 38117: 172517 | 172519 | 173251