Attachment 173274 Details for Bug 37360 – Bug 37360: (follow-up) added bool type to modborrowers

[patch] Bug 37360: (follow-up) added bool type to modborrowers

Bug-37360-follow-up-added-bool-type-to-modborrower.patch (text/plain), 3.22 KB, created by Jake Deery on 2024-10-24 14:35:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jake Deery

Created: 2024-10-24 14:35:42 UTC

Size: 3.22 KB

patch

obsolete

>From 40917264e829c22cad41cc5098a60d81dcc4ea4d Mon Sep 17 00:00:00 2001
>From: Jake Deery <jake.deery@ptfs-europe.com>
>Date: Fri, 4 Oct 2024 11:35:40 +0000
>Subject: [PATCH] Bug 37360: (follow-up) added bool type to modborrowers
>
>This follow-up patch adds a bool type to modborrowers, so that the
>options can be translated within the template files.
>---
> .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt    | 7 +++++++
> tools/modborrowers.pl                                      | 6 +-----
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>index 67cb3ebb91..476f98b2e4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>@@ -414,6 +414,13 @@
>                                                     There is no value defined for [% field.name | html %]
>                                                 [% END %]
>                                             [% END %]
>+                                            [% IF ( field.type == 'bool' ) %]
>+                                                <select name="[% field.name | html %]" >
>+                                                    <option value=""></option>
>+                                                    <option value="1">Yes</option>
>+                                                    <option value="0">No</option>
>+                                                </select>
>+                                            [% END %]
>                                             [% IF ( field.type == 'date' ) %]
>                                                 <input type="text" name="[% field.name | html %]" id="[% field.name | html %]" value="" size="10" maxlength="10" class="flatpickr" />
>                                                 <a href="#"  class="clear-date" id="clear-date-[% field.name | html %]" ><i class="fa fa-fw fa-trash-can"></i> Clear</a>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index f9f998c7fb..353f0e017a 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -196,10 +196,6 @@ if ( $op eq 'cud-show' || $op eq 'show' ) {
>     my @categories_option;
>     push @categories_option, { value => $_->categorycode, lib => $_->description } for @patron_categories;
>     unshift @categories_option, { value => "", lib => "" };
>-    my @protected_option;
>-    push @protected_option, { value => 1, lib => "Yes" };
>-    push @protected_option, { value => 0, lib => "No" };
>-    unshift @protected_option, { value => "", lib => "" };
>     my $bsort1 = GetAuthorisedValues("Bsort1");
>     my @sort1_option;
>     push @sort1_option, { value => $_->{authorised_value}, lib => $_->{lib} } for @$bsort1;
>@@ -342,7 +338,7 @@ if ( $op eq 'cud-show' || $op eq 'show' ) {
> 
>     if ($logged_in_user->is_superlibrarian) {
>         push @fields, { name => "password_expiration_date", type => "date" } ;
>-        push @fields, { name => "protected", type => "select", option => \@protected_option };
>+        push @fields, { name => "protected", type => "bool" };
>     }
> 
>     $template->param( 'patron_attributes_codes',  \@patron_attributes_codes );
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 37360: 170932 | 170991 | 172385 | 172977 | 172978 | 173273 | 173274 | 173275 | 173276