Bugzilla – Attachment 173294 Details for
Bug 33736
Add bookings to collect circulation report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33736: Add item location and filter by library to bookings to collect report
Bug-33736-Add-item-location-and-filter-by-library-.patch (text/plain), 3.31 KB, created by
Martin Renvoize (ashimema)
on 2024-10-24 16:41:06 UTC
(
hide
)
Description:
Bug 33736: Add item location and filter by library to bookings to collect report
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-24 16:41:06 UTC
Size:
3.31 KB
patch
obsolete
>From ddf3c17aeb7fd34cb549f4082f5bdf164a77248d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 16 Aug 2024 16:18:41 +0100 >Subject: [PATCH] Bug 33736: Add item location and filter by library to > bookings to collect report > >This patch adds a new 'Location' field to the bookings to collect >report. We display with the current item location or an onloan status >with the due date. > >We also add filtering for status != 'waiting' to the base query to rule >out items marked as ready for collection already (however, we don't yet >have a way of marking such a status so this won't have any effect yet). > >Sponsored-by: PTFS Europe Ltd >Signed-off-by: Esther Melander <esther@bywatersolutions.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > api/v1/swagger/paths/bookings.yaml | 2 ++ > .../prog/en/modules/circ/pendingbookings.tt | 21 ++++++++++++++++++- > 2 files changed, 22 insertions(+), 1 deletion(-) > >diff --git a/api/v1/swagger/paths/bookings.yaml b/api/v1/swagger/paths/bookings.yaml >index fcb2fba6317..3d33e0b978a 100644 >--- a/api/v1/swagger/paths/bookings.yaml >+++ b/api/v1/swagger/paths/bookings.yaml >@@ -45,6 +45,8 @@ > enum: > - biblio > - item >+ - item+strings >+ - item.checkout > - patron > - pickup_library > collectionFormat: csv >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt >index 8a787ee3d90..e309d5f669a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt >@@ -129,6 +129,7 @@ > let library = $("#library").find(":selected").val(); > return library; > }, >+ status: { '!=': 'waiting' }, > }; > > var bookings_table_url = '/api/v1/bookings?'; >@@ -138,7 +139,8 @@ > }, > "embed": [ > "biblio", >- "item", >+ "item+strings", >+ "item.checkout", > "patron", > "pickup_library" > ], >@@ -192,6 +194,23 @@ > } > } > }, >+ { >+ "data": "", >+ "title": "Location", >+ "searchable": false, >+ "orderable": true, >+ "render": function(data,type,row,meta) { >+ if ( row.item ) { >+ if ( row.item.checked_out_date ) { >+ return __("On loan, due: ") . $date(row.item.checked_out_date); >+ } else { >+ return row.item._strings.location.str; >+ } >+ } else { >+ return null; >+ } >+ } >+ }, > { > "data": "patron.firstname:patron.surname", > "title": "Patron", >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33736
:
158356
|
161044
|
165014
|
165144
|
165277
|
165278
|
165279
|
165280
|
170398
|
170399
|
170400
|
172716
|
172717
|
172718
|
172719
|
172720
|
172721
|
172765
|
172807
|
172808
|
172810
|
172823
|
172836
|
172837
|
172838
|
172839
|
172840
|
172841
|
172842
|
172843
|
172844
|
172845
|
173291
|
173292
|
173293
| 173294 |
173295
|
173296
|
173297
|
173298
|
173299
|
173300
|
173301
|
173302
|
173303
|
174582