Bugzilla – Attachment 173306 Details for
Bug 37582
SIP2 responses can contain newlines when a patron has multiple debarments
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37582: Tidy write_msg
Bug-37582-Tidy-writemsg.patch (text/plain), 1.72 KB, created by
ByWater Sandboxes
on 2024-10-24 20:06:57 UTC
(
hide
)
Description:
Bug 37582: Tidy write_msg
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2024-10-24 20:06:57 UTC
Size:
1.72 KB
patch
obsolete
>From fc0aaf6093f5c01dc892d98c2d868452de28d5d4 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 17 Sep 2024 14:52:22 -0400 >Subject: [PATCH] Bug 37582: Tidy write_msg > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> >--- > C4/SIP/Sip.pm | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm >index cfaa202dac..667e0c83ac 100644 >--- a/C4/SIP/Sip.pm >+++ b/C4/SIP/Sip.pm >@@ -187,9 +187,9 @@ sub boolspace { > # > > sub write_msg { >- my ($self, $msg, $server) = @_; >+ my ( $self, $msg, $server ) = @_; > my $terminator = $server->{account}->{terminator}; >- my $encoding = $server->{account}->{encoding}; >+ my $encoding = $server->{account}->{encoding}; > > $terminator ||= q{}; > $terminator = ( $terminator eq 'CR' ) ? $CR : $CRLF; >@@ -197,23 +197,23 @@ sub write_msg { > my $separator = $server->{account}->{convert_nonprinting_characters}; > $msg =~ s/[^[:print:]]/$separator/g if defined $separator; > >- $msg = encode($encoding, $msg) if ( $encoding ); >+ $msg = encode( $encoding, $msg ) if ($encoding); > > my $cksum; > > # $msg = encode_utf8($msg); > if ($error_detection) { >- if (defined($self->{seqno})) { >+ if ( defined( $self->{seqno} ) ) { > $msg .= 'AY' . $self->{seqno}; > } > $msg .= 'AZ'; > $cksum = checksum($msg); >- $msg .= sprintf('%04.4X', $cksum); >+ $msg .= sprintf( '%04.4X', $cksum ); > } > > STDOUT->autoflush(1); > print $msg, $terminator; >- siplog("LOG_INFO", "OUTPUT MSG: '$msg'"); >+ siplog( "LOG_INFO", "OUTPUT MSG: '$msg'" ); > > $last_response = $msg; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37582
:
171642
|
171643
|
171644
|
173081
|
173082
|
173306
|
173502
|
173503
|
173712
|
173715