Attachment 17331 Details for Bug 10019 – Bug 10019: Fix for userid containing UTF8 chars

[patch] Bug 10019: Fix for userid containing UTF8 chars

Bug-10019-Fix-for-userid-containing-UTF8-chars.patch (text/plain), 1.54 KB, created by Marcel de Rooy on 2013-04-10 08:21:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2013-04-10 08:21:15 UTC

Size: 1.54 KB

patch

obsolete

>From 44286d7d25e198dba29334e2bd9f62ddd2ee08d2 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 10 Apr 2013 10:13:52 +0200
>Subject: [PATCH] Bug 10019: Fix for userid containing UTF8 chars
>Content-Type: text/plain; charset=utf-8
>
>Decodes userid on two places in checkauth of C4/Auth.pm
>
>Test plan:
>Include some non-Latin characters in your userid (loginname). Arab, Chinese?
>Login into opac and check user page.
>Go to staff (no new login), check your login name at various places.
>Logout, login via staff.
>Do the same.
>Go to opac again (no new login), check user page.
>Optionally: Remove all your sessions from table. Do a login. Check sessions.
>---
> C4/Auth.pm |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index ca061b5..c96c765 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -674,6 +674,7 @@ sub checkauth {
>             $ip       = $session->param('ip');
>             $lasttime = $session->param('lasttime');
>             $userid   = $session->param('id');
>+            utf8::decode($userid);
>             $sessiontype = $session->param('sessiontype') || '';
>         }
>         if ( ( ($query->param('koha_login_context')) && ($query->param('userid') ne $session->param('id')) )
>@@ -749,6 +750,7 @@ sub checkauth {
>             -HttpOnly => 1
>         );
>     $userid = $query->param('userid');
>+    utf8::decode($userid);
>         if (   ( $cas && $query->param('ticket') )
>             || $userid
>             || ( my $pki_field = C4::Context->preference('AllowPKIAuth') ) ne
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 10019: 17331 | 17332