Attachment 173311 Details for Bug 38020 – Bug 38020: Change form to submit link

[patch] Bug 38020: Change form to submit link

Bug-38020-Change-form-to-submit-link.patch (text/plain), 2.88 KB, created by David Nind on 2024-10-25 04:48:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-25 04:48:53 UTC

Size: 2.88 KB

patch

obsolete

>From b66a4e6b5a638df0605050e87fae9d9e20178d40 Mon Sep 17 00:00:00 2001
>From: Yanjun Li <yanjun.li@bywatersolutions.com>
>Date: Thu, 24 Oct 2024 20:51:12 +0000
>Subject: [PATCH] Bug 38020: Change form to submit link
>
>To test:
>
>1. Create a list in the staff interface
>2. Go to lists
>3. View the list
>4. Click the Edit dropdown
>5. Notice the two dropdown options for Edit list and Delete list have different formatting and look different
>6. Apply patch
>7. Try steps 1 through 4 again
>8. The delete list button form looks right, and delete function works
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/includes/virtualshelves-toolbar.inc        | 10 +++-------
> .../prog/en/modules/virtualshelves/shelves.tt          |  1 +
> 2 files changed, 4 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
>index a63a914d6a..ad2c1860fd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
>@@ -16,13 +16,9 @@
>             <ul class="dropdown-menu">
>                 <li><a class="dropdown-item" href="/cgi-bin/koha/virtualshelves/shelves.pl?op=edit_form&amp;shelfnumber=[% shelf.shelfnumber | uri %]&amp;referer=[% op | uri %]">Edit list</a></li>
>                 <li>
>-                    <form id="deleteshelf_toolbar_form" action="shelves.pl" method="post">
>-                        [% INCLUDE 'csrf-token.inc' %]
>-                        <input type="hidden" name="op" value="cud-delete" />
>-                        <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber | html %]" />
>-                        <button type="submit" class="btn btn-default delete-list">Delete list</button>
>-                    </form>
>-                </li>
>+                    [% INCLUDE 'csrf-token.inc' %]
>+                    <a class="submit-form-link dropdown-item" href="#" data-shelfnumber="[% shelf.shelfnumber | html %]" data-method="post" data-action="shelves.pl" data-op="cud-delete" data-confirmation-msg="[% t('Are you sure you want to delete this list?') | html %]">Delete List</a>
>+               </li>
>             </ul>
>         </div>
>         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index c9c06745b1..34b7f80a42 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -607,6 +607,7 @@
> [% MACRO jsinclude BLOCK %]
>     [% INCLUDE 'datatables.inc' %]
>     [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %]
>+    [% Asset.js("js/form-submit.js") | $raw %]
>     [% IF print %]
>         <script>
>             $( document ).ready(function() {
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38020: 173307 | 173311 | 173724 | 173725 | 173747 | 173748 | 173749