Bugzilla – Attachment 173316 Details for
Bug 38222
Let staff pick a cancellation reason when canceling a booking
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed
Bug-38222-follow-up-Reset-overflow-property-of-mod.patch (text/plain), 2.41 KB, created by
Martin Renvoize (ashimema)
on 2024-10-25 07:28:34 UTC
(
hide
)
Description:
Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-25 07:28:34 UTC
Size:
2.41 KB
patch
obsolete
>From cbea6a681606f8d61da5ec7c0a56746df8b317df Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Thu, 24 Oct 2024 12:18:40 +0000 >Subject: [PATCH] Bug 38222: (follow-up) Reset overflow property of modal-body > to prevent clipping of combobox options instead of position: fixed >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this. > >Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> >Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/includes/modals/cancel_booking.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc >index 5cc699d8999..19c3074dd91 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc >@@ -8,7 +8,7 @@ > <h1 class="modal-title" id="cancelBookingLabel">Cancel booking</h1> > <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> >- <div class="modal-body"> >+ <div class="modal-body overflow-visible"> > <div id="cancel_booking_result"></div> > <input type="hidden" name="booking_id" id="cancel_booking_id"> > <p>Are you sure you want to cancel this booking?</p> >@@ -17,7 +17,7 @@ > <div class="combobox-container"> > <label for="cancellation-reason" class="form-label">Cancellation Reason:</label> > <input type="text" id="cancellation-reason" name="cancellation_reason" class="form-control" /> >- <ul id="cancellation-reason-list" class="dropdown-menu position-fixed" style="max-height: 200px; overflow-y: auto; max-width: fit-content;"> >+ <ul id="cancellation-reason-list" class="dropdown-menu"> > [% IF booking_cancellation.count %] > [% FOR reason IN booking_cancellation %] > <li> >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38222
:
173230
|
173231
|
173232
|
173233
|
173264
|
173265
|
173277
|
173278
|
173281
|
173282
|
173312
|
173313
|
173314
|
173315
| 173316 |
173317
|
173318
|
173319
|
173320
|
173321
|
173322
|
173323
|
173336
|
173337
|
173338
|
173339