Attachment 173322 Details for Bug 38222 – Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close

[patch] Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close

Bug-38222-QA-follow-up-DRY-event-listener-setup-fo.patch (text/plain), 3.47 KB, created by Paul Derscheid on 2024-10-25 09:05:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Derscheid

Created: 2024-10-25 09:05:57 UTC

Size: 3.47 KB

patch

obsolete

>From aaab679ead68cb1477a40fd3b067e3951530781c Mon Sep 17 00:00:00 2001
>From: Paul Derscheid <paul.derscheid@lmscloud.de>
>Date: Fri, 25 Oct 2024 07:41:07 +0000
>Subject: [PATCH] Bug 38222: (QA follow-up) DRY event listener setup for
> combobox resets on modal close
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Sponsored-by: BÃ¼chereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt    | 4 ----
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 -----
> .../intranet-tmpl/prog/en/modules/members/moremember.tt     | 4 ----
> koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js     | 6 ++++++
> 4 files changed, 6 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>index 2610464c65..31155c6436 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>@@ -386,10 +386,6 @@
>             placeholder: _("Select or type a reason"),
>         });
> 
>-        document.getElementById("cancelBookingModal")?.addEventListener('hide.bs.modal', () => {
>-            $("#cancellation-reason").comboBox('reset');
>-        });
>-
>         function handleFilter(e, text, filterStates) {
>             const target = e.target;
>             const { filter } = target.dataset;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 26a89d1e83..e96fa9f148 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -1148,11 +1148,6 @@
>                 displayProperty: 'name',
>                 placeholder: _("Select or type a reason"),
>             });
>-
>-            document.getElementById("cancelBookingModal")?.addEventListener('hide.bs.modal', () => {
>-                $("#cancellation-reason").comboBox('reset');
>-            });
>-
>         });
>     </script>
>     [% INCLUDE 'str/members-menu.inc' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 7e0c205b45..dbd55ea139 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -832,10 +832,6 @@
>                 displayProperty: 'name',
>                 placeholder: _("Select or type a reason"),
>             });
>-
>-            document.getElementById("cancelBookingModal")?.addEventListener('hide.bs.modal', () => {
>-                $("#cancellation-reason").comboBox('reset');
>-            });
>         });
>     </script>
>     [% Asset.js("js/tables/bookings.js") | $raw %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js
>index d34196b129..f146eaa169 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js
>@@ -6,6 +6,12 @@
>         .getElementById("cancelBookingForm")
>         ?.addEventListener("submit", handleSubmit);
> 
>+    document
>+        .getElementById("cancelBookingModal")
>+        ?.addEventListener("hide.bs.modal", () => {
>+            $("#cancellation-reason").comboBox("reset");
>+        });
>+
>     async function handleSubmit(e) {
>         e.preventDefault();
> 
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 38222: 173230 | 173231 | 173232 | 173233 | 173264 | 173265 | 173277 | 173278 | 173281 | 173282 | 173312 | 173313 | 173314 | 173315 | 173316 | 173317 | 173318 | 173319 | 173320 | 173321 | 173322 | 173323 | 173336 | 173337 | 173338 | 173339