Attachment 17339 Details for Bug 10008 – Bug 10008 - Serials search results 'Opened' tab should be 'Open'

[patch] Bug 10008 - Serials search results 'Opened' tab should be 'Open'

Bug-10008---Serials-search-results-Opened-tab-shou.patch (text/plain), 2.72 KB, created by Jonathan Druart on 2013-04-10 12:14:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-04-10 12:14:45 UTC

Size: 2.72 KB

patch

obsolete

>From ed0ce4758e54ec4b3a9b599cdbc9270ec2408d4b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 9 Apr 2013 15:27:15 -0400
>Subject: [PATCH] Bug 10008 - Serials search results 'Opened' tab should be
> 'Open'
>
>The searials search results "Opened" tab should be labeled "Open." This
>patch makes this correction and changes the wording in another place
>which used "opened." Markup has also been added to maintain consistency
>in display of messages.
>
>To test, perform a search for a subscription. If your search returns
>results you should see an "Open" and a "Closed" tab. To test other
>affected changes perform searches which return no results, only open
>subscriptions, or only closed subscriptions. "No results" messages
>should display correctly and consistently.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../prog/en/modules/serials/serials-search.tt            |   14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>index 0c937bf..459a80a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>@@ -105,7 +105,7 @@
>         [% IF ( total ) %]
>           <div id="serialstabs" class="toptabs" style="clear:both;">
>             <ul class="ui-tabs-nav">
>-              <li><a href="#opened">Opened ([% openedsubscriptions.size || 0 %])</a></li>
>+              <li><a href="#opened">Open ([% openedsubscriptions.size || 0 %])</a></li>
>               <li><a href="#closed">Closed ([% closedsubscriptions.size || 0 %])</a></li>
>             </ul>
>             <div id="opened">
>@@ -188,7 +188,9 @@
>                   </tbody>
>                 </table>
>               [% ELSE %]
>-                There is no opened subscription for your search.
>+                <div class="dialog message">
>+                  <p>Your search returned no open subscriptions.</p>
>+                </div>
>               [% END %]
>             </div>
>             <div id="closed">
>@@ -252,10 +254,16 @@
>                   </tbody>
>                 </table>
>               [% ELSE %]
>-                There is no closed subscription for your search.
>+                <div class="dialog message">
>+                  <p>Your search returned no closed subscriptions.</p>
>+                </div>
>               [% END %]
>             </div>
>           </div>
>+        [% ELSE %]
>+            <div class="dialog message">
>+              <p>Your search returned no results.</p>
>+            </div>
>         [% END %]
>       [% END %]
>     </div>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10008: 17318 | 17326 | 17339