Attachment 173403 Details for Bug 36822 – Bug 36822: Shibboleth - Add discard_changes

[patch] Bug 36822: Shibboleth - Add discard_changes

Bug-36822-Shibboleth---Add-discardchanges.patch (text/plain), 1.06 KB, created by David Nind on 2024-10-25 18:02:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-10-25 18:02:51 UTC

Size: 1.06 KB

patch

obsolete

>From 1071310a142c1a65d9772dfa2202d3c429d6b627 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Fri, 25 Oct 2024 14:36:23 +0000
>Subject: [PATCH] Bug 36822: Shibboleth - Add discard_changes
>
>Test plan:
>1) Apply only Shibboleth tests patch
>2) Run that test file:
>$ prove t/db_dependent/Auth_with_shibboleth.t
>3) Verify tests fail with the updated_on error message.
>4) Apply this patch. Repeat 2) Verify tests now pass.
>
>Co-authored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/Auth_with_shibboleth.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm
>index 3e6f42b57c..e3eb281cfc 100644
>--- a/C4/Auth_with_shibboleth.pm
>+++ b/C4/Auth_with_shibboleth.pm
>@@ -135,6 +135,8 @@ sub _autocreate {
>     }
> 
>     my $patron = Koha::Patron->new( \%borrower )->store;
>+    $patron->discard_changes;
>+
>     C4::Members::Messaging::SetMessagingPreferencesFromDefaults(
>         {
>             borrowernumber => $patron->borrowernumber,
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 36822: 173373 | 173374 | 173375 | 173376 | 173377 | 173385 | 173386 | 173387 | 173388 | 173389 | 173391 | 173392 | 173393 | 173394 | 173395 | 173402 | 173403 | 173404 | 173405 | 173406 | 173646 | 173903 | 173904 | 173905 | 173906 | 173907 | 173908 | 173909 | 174523 | 174525